Skip to content
This repository has been archived by the owner on Nov 20, 2018. It is now read-only.

Fix the broken scheme-less GetTokenAsync overload #823

Closed
kevinchalet opened this issue Apr 24, 2017 · 3 comments
Closed

Fix the broken scheme-less GetTokenAsync overload #823

kevinchalet opened this issue Apr 24, 2017 · 3 comments
Assignees
@HaoK
Labels
3 - Done bug
Milestone
2.0.0-preview1

Comments

@kevinchalet
Copy link
Contributor

The GetTokenAsync() overload that doesn't require a scheme is convenient... but broken, as it tries to call the other overload with a null scheme, which results in an ArgumentNullException being thrown at runtime:

image

https://github.com/aspnet/HttpAbstractions/blob/dev/src/Microsoft.AspNetCore.Authentication.Abstractions/TokenExtensions.cs#L135

/cc @HaoK @Tratcher
@HaoK
Copy link
Member

HaoK commented Apr 24, 2017

Yeah, I should add a test for this one :)

@HaoK HaoK self-assigned this Apr 24, 2017
@HaoK HaoK mentioned this issue Apr 24, 2017
Closed
@HaoK
Copy link
Member

HaoK commented Apr 24, 2017

3085f01

@HaoK HaoK closed this as completed Apr 24, 2017
@HaoK HaoK added this to the 2.0.0-preview1 milestone Apr 24, 2017
@kevinchalet
Copy link
Contributor Author

Thanks! 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@HaoK HaoK

Labels
3 - Done bug
Projects
None yet
Milestone
2.0.0-preview1
Development

No branches or pull requests
2 participants
@HaoK @kevinchalet