Skip to content
This repository has been archived by the owner on Nov 20, 2018. It is now read-only.

Consider looking for InvokeAsync too when configuring middleware through UseMiddleware #786

Closed
javiercn opened this issue Mar 9, 2017 · 1 comment
Assignees

Comments

@javiercn
Copy link
Member

javiercn commented Mar 9, 2017

UseMiddleware() will fail if your middleware has InvokeAsync instead of Invoke (which is a very common pattern) (VS will add Async suffix when you ctrl+. and a lot of people follow that convention)

We probably want to also change IMiddleware to support this in some way.
https://github.com/aspnet/HttpAbstractions/blob/dev/src/Microsoft.AspNetCore.Http.Abstractions/IMiddleware.cs#L23

@muratg
Copy link

muratg commented Mar 20, 2017

We'll try to do this. If there's both Invoke and InvokeAsync, we'll throw.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants