Skip to content
This repository has been archived by the owner on Nov 20, 2018. It is now read-only.

ParsingHelper duplications #762

Closed
JunTaoLuo opened this issue Jan 27, 2017 · 0 comments
Closed

ParsingHelper duplications #762

JunTaoLuo opened this issue Jan 27, 2017 · 0 comments
Assignees

Comments

@JunTaoLuo
Copy link
Contributor

JunTaoLuo commented Jan 27, 2017

For example:

https://github.com/aspnet/HttpAbstractions/blob/dev/src/Microsoft.AspNetCore.Http/Internal/ParsingHelpers.cs#L14-L361

and

https://github.com/aspnet/HttpAbstractions/blob/dev/src/Microsoft.AspNetCore.Http.Abstractions/Internal/HeaderSegment.cs
https://github.com/aspnet/HttpAbstractions/blob/dev/src/Microsoft.AspNetCore.Http.Abstractions/Internal/HeaderSegmentCollection.cs

There are only minor differences but we may be able to remove one and use the other. The reason we don't do it now is because both types are internal to their own assembly. There looks to be other duplications as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants