Skip to content
This repository has been archived by the owner on Nov 20, 2018. It is now read-only.

GetCommaSeparatedValues should strip out empty strings #722

Closed
JunTaoLuo opened this issue Oct 7, 2016 · 0 comments
Closed

GetCommaSeparatedValues should strip out empty strings #722

JunTaoLuo opened this issue Oct 7, 2016 · 0 comments
Assignees
@JunTaoLuo
Labels
3 - Done bug
Milestone
2.0.0-preview2

Comments

@JunTaoLuo
Copy link
Contributor

We should ignore empty headers since they are not meaningful. Currently, parsing ,, will generate three empty strings {string[3]}: {"","",""}. We should instead check whether the parsed values are empty here: https://github.com/aspnet/HttpAbstractions/blob/dev/src/Microsoft.AspNetCore.Http.Abstractions/Internal/ParsingHelpers.cs#L29
@muratg muratg added this to the 1.2.0 milestone Nov 2, 2016
@muratg muratg modified the milestones: 1.2.0, 2.0.0 Jan 12, 2017
@muratg muratg modified the milestones: 2.0.0-preview1, 2.0.0-preview2 Apr 21, 2017
JunTaoLuo added a commit that referenced this issue May 15, 2017
@JunTaoLuo
Ignore empty header values #722
ac1f19e
@JunTaoLuo JunTaoLuo mentioned this issue May 15, 2017
Merged
JunTaoLuo added a commit that referenced this issue May 17, 2017
@JunTaoLuo
Ignore empty header values #722
7bb3170
JunTaoLuo added a commit that referenced this issue May 17, 2017
@JunTaoLuo
Ignore empty header values #722
07470d4
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JunTaoLuo JunTaoLuo

Labels
3 - Done bug
Projects
None yet
Milestone
2.0.0-preview2
Development

No branches or pull requests
2 participants
@muratg @JunTaoLuo