Skip to content
This repository has been archived by the owner on Nov 20, 2018. It is now read-only.

Move feature implementations into Microsoft.AspNetCore.Http.Features namespace #592

Closed
dougbu opened this issue Mar 21, 2016 · 2 comments
Closed

Move feature implementations into Microsoft.AspNetCore.Http.Features namespace #592

dougbu opened this issue Mar 21, 2016 · 2 comments
Assignees
@dougbu
Labels
3 - Done
Milestone
1.0.0-rc2

Comments

@dougbu
Copy link
Member

dougbu commented Mar 21, 2016

#589 exposes all of the feature interfaces publicly. But the feature implementations remain in Microsoft.AspNetCore.Http.Features.Internal and Microsoft.AspNetCore.Http.Features.Authentication.Internal. Since the feature implementations are used in Kestrel and supported, they should also be moved to Microsoft.AspNetCore.Http.Features and Microsoft.AspNetCore.Http.Features.Authentication.

See comment here for example.
@dougbu
Copy link
Member Author

dougbu commented Mar 21, 2016

Self-assigning because I was playing with this cleanup already.

@dougbu dougbu self-assigned this Mar 21, 2016
@dougbu dougbu added this to the 1.0.0-rc2 milestone Mar 21, 2016
This was referenced Mar 21, 2016
Closed
Closed
@dougbu dougbu mentioned this issue Mar 23, 2016
Closed
dougbu added a commit that referenced this issue Mar 30, 2016
@dougbu
Move some implementations (all feature implementations) out of `.Inte…
23e9f90 
…rnal` namespaces

- #549, #592
- move feature implementations to `Microsoft.AspNetCore.Http.Features` and `...Authentication.Features`
- move `DefaultHttpContext`, `HttpContextAccessor`, `HttpContextFactory`, `FormCollection` and
  `HeaderDictionary` to `Microsoft.AspNetCore.Http`
- move `FormFile` to `Microsoft.AspNetCore.Http.Internal`
 - that and `Microsoft.AspNetCore.Http.Authentication.Internal` are the remaining `.Internal` namespaces

nits:
- remove a couple of parameterless constructors
- add / fill subfolders to align with new namespaces
- remove all use of (unnecessary) "T:..." `<see cref=""/>` values
dougbu added a commit to aspnet/Hosting that referenced this issue Mar 30, 2016
@dougbu
React to HttpAbstractions namespace changes
298dd5a 
- aspnet/HttpAbstractions#549 and aspnet/HttpAbstractions#592
- clean up `using`s
dougbu added a commit to aspnet/KestrelHttpServer that referenced this issue Mar 30, 2016
@dougbu
React to HttpAbstractions namespace changes
98065a1 
- aspnet/HttpAbstractions#549 and aspnet/HttpAbstractions#592
- clean up `using`s
dougbu added a commit to aspnet/HttpSysServer that referenced this issue Mar 30, 2016
@dougbu
React to HttpAbstractions namespace changes
5ba2022 
- aspnet/HttpAbstractions#549 and aspnet/HttpAbstractions#592
- clean up `using`s
dougbu added a commit to aspnet/IISIntegration that referenced this issue Mar 30, 2016
@dougbu
React to HttpAbstractions namespace changes
93394c0 
- aspnet/HttpAbstractions#549 and aspnet/HttpAbstractions#592
- clean up `using`s
dougbu added a commit to aspnet/CORS that referenced this issue Mar 30, 2016
@dougbu
React to HttpAbstractions namespace changes
bd60e32 
- aspnet/HttpAbstractions#549 and aspnet/HttpAbstractions#592
- clean up `using`s
dougbu added a commit to aspnet/Routing that referenced this issue Mar 30, 2016
@dougbu
React to HttpAbstractions namespace changes
781bf21 
- aspnet/HttpAbstractions#549 and aspnet/HttpAbstractions#592
- clean up `using`s
dougbu added a commit to aspnet/StaticFiles that referenced this issue Mar 30, 2016
@dougbu
React to HttpAbstractions namespace changes
6702060 
- aspnet/HttpAbstractions#549 and aspnet/HttpAbstractions#592
- clean up `using`s
dougbu added a commit to aspnet/Antiforgery that referenced this issue Mar 30, 2016
@dougbu
React to HttpAbstractions namespace changes
1d5496f 
- aspnet/HttpAbstractions#549 and aspnet/HttpAbstractions#592
- clean up `using`s
dougbu added a commit to aspnet/Diagnostics that referenced this issue Mar 30, 2016
@dougbu
React to HttpAbstractions namespace changes
709cf73 
- aspnet/HttpAbstractions#549 and aspnet/HttpAbstractions#592
- clean up `using`s
dougbu added a commit to aspnet/Security that referenced this issue Mar 30, 2016
@dougbu
React to HttpAbstractions namespace changes
791ac9e 
- aspnet/HttpAbstractions#549 and aspnet/HttpAbstractions#592
- clean up `using`s
dougbu added a commit to aspnet/Mvc that referenced this issue Mar 30, 2016
@dougbu
React to HttpAbstractions namespace changes
2a73d8d 
- aspnet/HttpAbstractions#549 and aspnet/HttpAbstractions#592
- clean up `using`s
dougbu added a commit to aspnet/Identity that referenced this issue Mar 30, 2016
@dougbu
React to HttpAbstractions namespace changes
d61a08e 
- aspnet/HttpAbstractions#549 and aspnet/HttpAbstractions#592
- clean up `using`s
dougbu added a commit to aspnet/Entropy that referenced this issue Mar 30, 2016
@dougbu
React to HttpAbstractions namespace changes
63c24f6 
- aspnet/HttpAbstractions#549 and aspnet/HttpAbstractions#592
- clean up `using`s
dougbu added a commit to aspnet/MusicStore that referenced this issue Mar 30, 2016
@dougbu
React to HttpAbstractions namespace changes
fd866f0 
- aspnet/HttpAbstractions#549 and aspnet/HttpAbstractions#592
- clean up `using`s
This was referenced Mar 30, 2016
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 30, 2016
Closed
Closed
Closed
Closed
Closed
Closed
Closed
dougbu added a commit that referenced this issue Mar 30, 2016
@dougbu
Move some implementations (all feature implementations) out of `.Inte…
6725d68 
…rnal` namespaces

- #549, #592
- move feature implementations to `Microsoft.AspNetCore.Http.Features` and `...Authentication.Features`
- move `DefaultHttpContext`, `HttpContextAccessor`, `HttpContextFactory`, `FormCollection` and
  `HeaderDictionary` to `Microsoft.AspNetCore.Http`
- move `FormFile` to `Microsoft.AspNetCore.Http.Internal`
 - that and `Microsoft.AspNetCore.Http.Authentication.Internal` are the remaining `.Internal` namespaces

nits:
- remove a couple of parameterless constructors
- add / fill subfolders to align with new namespaces
- remove all use of (unnecessary) "T:..." `<see cref=""/>` values
dougbu added a commit to aspnet/Hosting that referenced this issue Mar 30, 2016
@dougbu
React to HttpAbstractions namespace changes
6e87b51 
- aspnet/HttpAbstractions#549 and aspnet/HttpAbstractions#592
- clean up `using`s
dougbu added a commit to aspnet/KestrelHttpServer that referenced this issue Mar 30, 2016
@dougbu
React to HttpAbstractions namespace changes
c828faf 
- aspnet/HttpAbstractions#549 and aspnet/HttpAbstractions#592
- clean up `using`s
dougbu added a commit to aspnet/HttpSysServer that referenced this issue Mar 30, 2016
@dougbu
React to HttpAbstractions namespace changes
84c8975 
- aspnet/HttpAbstractions#549 and aspnet/HttpAbstractions#592
- clean up `using`s
dougbu added a commit to aspnet/IISIntegration that referenced this issue Mar 30, 2016
@dougbu
React to HttpAbstractions namespace changes
52e5ccd 
- aspnet/HttpAbstractions#549 and aspnet/HttpAbstractions#592
- clean up `using`s
dougbu added a commit to aspnet/CORS that referenced this issue Mar 30, 2016
@dougbu
React to HttpAbstractions namespace changes
5a3ea74 
- aspnet/HttpAbstractions#549 and aspnet/HttpAbstractions#592
- clean up `using`s
dougbu added a commit to aspnet/Routing that referenced this issue Mar 30, 2016
@dougbu
React to HttpAbstractions namespace changes
67f4243 
- aspnet/HttpAbstractions#549 and aspnet/HttpAbstractions#592
- clean up `using`s
dougbu added a commit to aspnet/StaticFiles that referenced this issue Mar 30, 2016
@dougbu
React to HttpAbstractions namespace changes
74d2c13 
- aspnet/HttpAbstractions#549 and aspnet/HttpAbstractions#592
- clean up `using`s
dougbu added a commit to aspnet/Antiforgery that referenced this issue Mar 30, 2016
@dougbu
React to HttpAbstractions namespace changes
65a2b8d 
- aspnet/HttpAbstractions#549 and aspnet/HttpAbstractions#592
- clean up `using`s
dougbu added a commit to aspnet/Diagnostics that referenced this issue Mar 30, 2016
@dougbu
React to HttpAbstractions namespace changes
f1a0243 
- aspnet/HttpAbstractions#549 and aspnet/HttpAbstractions#592
- clean up `using`s
dougbu added a commit to aspnet/Security that referenced this issue Mar 30, 2016
@dougbu
React to HttpAbstractions namespace changes
16a0482 
- aspnet/HttpAbstractions#549 and aspnet/HttpAbstractions#592
- clean up `using`s
dougbu added a commit to aspnet/Mvc that referenced this issue Mar 30, 2016
@dougbu
React to HttpAbstractions namespace changes
6bf25ce 
- aspnet/HttpAbstractions#549 and aspnet/HttpAbstractions#592
- clean up `using`s
dougbu added a commit to aspnet/Identity that referenced this issue Mar 30, 2016
@dougbu
React to HttpAbstractions namespace changes
b2bf1a4 
- aspnet/HttpAbstractions#549 and aspnet/HttpAbstractions#592
- clean up `using`s
dougbu added a commit to aspnet/Entropy that referenced this issue Mar 30, 2016
@dougbu
React to HttpAbstractions namespace changes
9da3ca9 
- aspnet/HttpAbstractions#549 and aspnet/HttpAbstractions#592
- clean up `using`s
dougbu added a commit to aspnet/MusicStore that referenced this issue Mar 30, 2016
@dougbu
React to HttpAbstractions namespace changes
20a24a2 
- aspnet/HttpAbstractions#549 and aspnet/HttpAbstractions#592
- clean up `using`s
@dougbu
Copy link
Member Author

dougbu commented Mar 31, 2016

@dougbu dougbu closed this as completed Mar 31, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dougbu dougbu

Labels
3 - Done
Projects
None yet
Milestone
1.0.0-rc2
Development

No branches or pull requests
1 participant
@dougbu