Skip to content
This repository has been archived by the owner on Nov 20, 2018. It is now read-only.

Dispose the FileBufferingReadStream created by ReadFormAsync #393

Closed
Tratcher opened this issue Sep 8, 2015 · 1 comment
Closed

Dispose the FileBufferingReadStream created by ReadFormAsync #393

Tratcher opened this issue Sep 8, 2015 · 1 comment
Assignees
Milestone

Comments

@Tratcher
Copy link
Member

Tratcher commented Sep 8, 2015

BufferingHelper.EnableRewind creates a temp file to store the request buffer in if it gets too large. Currently this file is only deleted when closed by GC, where it could be deleted at the end of the given request. Register for Response.RegisterForDispose when the file is created.

https://github.com/aspnet/HttpAbstractions/blob/dev/src/Microsoft.AspNet.Http/BufferingHelper.cs#L47-L49

@Tratcher Tratcher added the bug label Sep 8, 2015
@muratg muratg added this to the 1.0.0-rc1 milestone Sep 9, 2015
@muratg muratg assigned cesarblum and unassigned cesarblum Oct 9, 2015
@muratg muratg modified the milestones: 1.0.0 backlog, 1.0.0-rc1 Oct 14, 2015
@muratg muratg modified the milestones: 1.0.0-rc2, 1.0.0 backlog Dec 11, 2015
@Tratcher Tratcher assigned BrennanConroy and unassigned Tratcher Dec 15, 2015
@BrennanConroy
Copy link
Member

fixed via #520

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants