Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

Add API to configure shutdown timeout #1031

Closed
davidfowl opened this issue Apr 21, 2017 · 7 comments
Closed

Add API to configure shutdown timeout #1031

davidfowl opened this issue Apr 21, 2017 · 7 comments

Comments

@davidfowl
Copy link
Member

Seems we only read it from configuration now.

@Tratcher
Copy link
Member

There's also StopAsync(this IWebHost host, TimeSpan timeout)

@davidfowl
Copy link
Member Author

Yea, there is, we should add a top level method for configuring options. Just like prefer hosting urls.

@muratg muratg added this to the 2.0.0-preview2 milestone Apr 24, 2017
@muratg
Copy link

muratg commented May 15, 2017

Related to #1016.

@BrennanConroy
Copy link
Member

What do we want to name the extension method?
public static IWebHostBuilder UseShutdownTimeout(this IWebHostBuilder hostBuilder, TimeSpan timeout)
Or
public static IWebHostBuilder ConfigureShutdownTimeout(this IWebHostBuilder hostBuilder, TimeSpan timeout)
Or
public static IWebHostBuilder SetShutdownTimeout(this IWebHostBuilder hostBuilder, TimeSpan timeout)

@Tratcher
Copy link
Member

UseShutdownTimeout would be the most consistent.

public static IWebHostBuilder UseUrls(this IWebHostBuilder hostBuilder, params string[] urls)

@davidfowl
Copy link
Member Author

I want to kill all of these extension methods and do this instead #1042

@BrennanConroy
Copy link
Member

03bdb40

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants