Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider making resource string helpers public #804

Closed
ajcvickers opened this issue Oct 6, 2014 · 1 comment
Closed

Consider making resource string helpers public #804

ajcvickers opened this issue Oct 6, 2014 · 1 comment
Assignees
@bricelam
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
1.0.0

Comments

@ajcvickers
Copy link
Member

No real need for them to be internal and makes testing across assemblies easier. Also makes it easier for app developers/integrators to get access to our exception messages for testing if they so choose.

We should also make the parameterized method (as opposed to the raw string) have the best name since it is most used.
@rowanmiller rowanmiller added this to the 1.0.0-rc1 milestone Oct 10, 2014
@bricelam bricelam modified the milestones: 1.0.0-beta2, 1.0.0-rc1 Nov 10, 2014
@bricelam bricelam mentioned this issue Nov 11, 2014
Merged
@bricelam
Copy link
Contributor

Blocked. Discussing proposed changes with the ASP.NET Engineering Team.

@bricelam bricelam mentioned this issue Nov 14, 2014
Merged
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Oct 15, 2022
@ajcvickers ajcvickers modified the milestones: 1.0.0-beta2, 1.0.0 Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bricelam bricelam

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
3 participants
@bricelam @ajcvickers @rowanmiller