Skip to content
This repository has been archived by the owner on Dec 8, 2018. It is now read-only.

Source code no longer expands/collapses #264

Closed
lodejard opened this issue Apr 8, 2016 · 5 comments
Closed

Source code no longer expands/collapses #264

lodejard opened this issue Apr 8, 2016 · 5 comments
Assignees
Milestone

Comments

@lodejard
Copy link

lodejard commented Apr 8, 2016

Clicking error no longer expands.

Html still has extra lines in the html, looks like javascript is busted

errorpage

@lodejard
Copy link
Author

lodejard commented Apr 8, 2016

Looks like the bug is here

    function frame(el) {
        ns(el).children(".source .collapsible").toggle();
    }

maybe should be something like

    function frame(el) {
        ns(".source .collapsible", el).toggle();
    }

@davidfowl
Copy link
Member

@ryanbrandenburg didn't you fix this?

@ryanbrandenburg
Copy link
Contributor

I fixed the collapse/expand on the exception details. I didn't even remember/know that the code was supposed to expand. #266 has a fix.

@Tratcher
Copy link
Member

Tratcher commented May 4, 2016

Reactivating as this does not appear to be fixed in the RC2 release branch.

@Tratcher Tratcher reopened this May 4, 2016
@Tratcher
Copy link
Member

Tratcher commented May 4, 2016

Nevermind, it was only fixed in dev.

@Tratcher Tratcher closed this as completed May 4, 2016
@Tratcher Tratcher added this to the 1.0.0 milestone May 4, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants