Skip to content
This repository has been archived by the owner on Dec 8, 2018. It is now read-only.

Remove RuntimeInfoMiddleware dependency on ILibraryManager by removing the list of packages #233

Closed
JunTaoLuo opened this issue Dec 17, 2015 · 6 comments
Assignees
Milestone

Comments

@JunTaoLuo
Copy link
Contributor

We need to update the RuntimeInfo middleware in this repo after aspnet/Hosting#514 removed platform services like ILibraryManager.

@JunTaoLuo JunTaoLuo added the bug label Dec 17, 2015
@davidfowl
Copy link
Member

We should just remove the package display.

@JunTaoLuo
Copy link
Contributor Author

Also clean up UseRuntimeInfoPage to use app.UseMiddleware<RuntimeInfoMiddleware>(options) instead.

@Eilon
Copy link
Member

Eilon commented Dec 30, 2015

@davidfowl I'm fine with not showing packages, but showing the DLLs is still important. What's the right way to get the list of loaded DLLs?

@davidfowl
Copy link
Member

There's no way to do that right now. There's a corefx issue I've been pushing but no progress yet.

@Eilon
Copy link
Member

Eilon commented Dec 30, 2015

Ok so for this item we'll just remove the package list, and I'll log a new bug to add the loaded DLL list instead.

Do you have a link to the CoreFX bug?

@Eilon
Copy link
Member

Eilon commented Dec 30, 2015

Here's the bug to list loaded DLLs in the info page: #237

@Eilon Eilon changed the title RuntimeInfoMiddleware needs ILibraryManager Remove RuntimeInfoMiddleware dependency on ILibraryManager by removing the list of packages Dec 30, 2015
@Eilon Eilon added this to the 1.0.0-rc2 milestone Dec 30, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants