-
Notifications
You must be signed in to change notification settings - Fork 318
Turn on scope validation by default #481
Comments
@pakrym before we turn this on by default need to look at the performance impact. |
Here's results from a benchmark I've added.
|
@danroth27 @DamianEdwards @Eilon do we want this on by default? Currently they can turn this on with a single line in program main. If we want to turn this on by default, we'll need to do it across our tests firsts. We were looking at this in DI triage with @davidfowl and @pakrym and we're not sure if this should be done. |
It would be really nice if this was on by default, but we would need to test the perf impact. |
Perhaps we should just update the templates to have it on by default for Development only? |
@DamianEdwards that sounds reasonable to me. And we would also enable it at least for a portion of the tests, right? |
That requires use to expose a callback here https://github.com/aspnet/Hosting/blob/51f77ea7f3b4a704691d0def9dd746fe0e32d5dc/src/Microsoft.AspNetCore.Hosting/WebHostBuilderExtensions.cs#L91 that exposes the |
For 2.0 we should consider turning on scope validation by default.
The text was updated successfully, but these errors were encountered: