Skip to content
This repository has been archived by the owner on Nov 2, 2018. It is now read-only.

Unique-ify the names of the various ServiceCollectionExtensions types #408

Closed
Eilon opened this issue May 26, 2016 · 2 comments
Closed

Unique-ify the names of the various ServiceCollectionExtensions types #408

Eilon opened this issue May 26, 2016 · 2 comments
Assignees
@NTaylorMullen
Labels
3 - Done bug
Milestone
1.0.0

Comments

@Eilon
Copy link
Member

Eilon commented May 26, 2016 •
edited by NTaylorMullen
Loading

Currently they conflict with type names in other assemblies and/or have super generic names (thus making the names somewhat useless). We should always give these types reasonably unique names describing not only what they extend, but what type of functionality they add.

Proposal:

  • Rename this to ServiceCollectionContainerBuilderExtensions
  • Rename this to ServiceCollectionServiceExtensions
  • Rename this to ServiceCollectionDescriptorExtensions
  • Rename this to ServiceProviderServiceExtensions
@Eilon Eilon added this to the 1.0.0 milestone May 26, 2016
@Eilon
Copy link
Member Author

Eilon commented May 26, 2016

@danroth27 FYI

NTaylorMullen added a commit that referenced this issue May 26, 2016
@NTaylorMullen
Unique-ify extension types to not be ambiguous cross repo.
60ca512 
- Also updated test class names to reflect new extension naming.

#408
@NTaylorMullen NTaylorMullen mentioned this issue May 26, 2016
Merged
@NTaylorMullen
Copy link
Member

60ca512

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NTaylorMullen NTaylorMullen

Labels
3 - Done bug
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@Eilon @NTaylorMullen