Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The AddInstance extension method on IServiceCollection was renamed to AddSingleton #119

Open
pranavkm opened this issue Nov 26, 2015 · 0 comments
Open

The AddInstance extension method on IServiceCollection was renamed to AddSingleton #119

pranavkm opened this issue Nov 26, 2015 · 0 comments
Labels
Announcement Breaking change
Milestone
1.0.0-rc2

Comments

@pranavkm
Copy link
Contributor

Per aspnet/DependencyInjection#319, IServiceCollection.AddInstance was renamed to IServiceCollection.AddSingleton. This brings it inline with the other two AddSingleton extension methods:

serviceCollection.AddInstance(new MyService);
serviceCollection.AddSingleton(new MyService());

Use aspnet/DependencyInjection#332 for further discussion
@pranavkm pranavkm added this to the 1.0.0-rc2 milestone Nov 26, 2015
@aspnet aspnet locked and limited conversation to collaborators Nov 26, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Announcement Breaking change
Projects
None yet
Milestone
1.0.0-rc2
Development

No branches or pull requests
2 participants
@pranavkm @Eilon