From ef02a5b924e93e712972b73f53604890823becf4 Mon Sep 17 00:00:00 2001 From: Chuck Adams Date: Sun, 23 Feb 2025 14:30:55 -0700 Subject: [PATCH] fix: make 'popular' categories use active_installs desc for order (#175) --- app/Services/Plugins/QueryPluginsService.php | 6 +++--- app/Services/Themes/QueryThemesService.php | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/app/Services/Plugins/QueryPluginsService.php b/app/Services/Plugins/QueryPluginsService.php index 5837e59..0532310 100644 --- a/app/Services/Plugins/QueryPluginsService.php +++ b/app/Services/Plugins/QueryPluginsService.php @@ -97,12 +97,12 @@ private static function applyTag(Builder $query, string $tag): void */ private static function applyBrowse(Builder $query, string $browse): void { - // TODO: replicate 'featured' browse (currently it's identical to 'popular') + // TODO: replicate 'featured' browse (currently it's identical to 'top-rated') match ($browse) { 'new' => $query->reorder('added', 'desc'), 'updated' => $query->reorder('last_updated', 'desc'), - 'top-rated', 'popular', 'featured' => $query->reorder('rating', 'desc'), - default => $query->reorder('active_installs', 'desc'), + 'top-rated', 'featured' => $query->reorder('rating', 'desc'), + default => $query->reorder('active_installs', 'desc'), // 'popular' is also the default }; } diff --git a/app/Services/Themes/QueryThemesService.php b/app/Services/Themes/QueryThemesService.php index 36f325b..e50f645 100644 --- a/app/Services/Themes/QueryThemesService.php +++ b/app/Services/Themes/QueryThemesService.php @@ -48,9 +48,9 @@ private static function applyBrowse(Builder $query, string $browse): void { // TODO: replicate 'featured' browse (currently it's identical to 'popular') match ($browse) { - 'popular', 'featured' => $query->reorder('rating', 'desc'), + 'featured' => $query->reorder('rating', 'desc'), 'new' => $query->reorder('creation_time', 'desc'), - default => null, + default => $query->reorder('active_installs', 'desc'), // 'popular' is also the default }; }