From d65c0145bf6c80eeedc22ca946627f8bd554a15f Mon Sep 17 00:00:00 2001 From: Alex Eagle Date: Thu, 20 Feb 2025 12:18:22 -0800 Subject: [PATCH 1/2] chore(deps): try new rules_python RC --- examples/MODULE.bazel | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/MODULE.bazel b/examples/MODULE.bazel index aaaef6c..6d8023a 100644 --- a/examples/MODULE.bazel +++ b/examples/MODULE.bazel @@ -4,7 +4,7 @@ bazel_dep(name = "aspect_rules_py", version = "1.3.2") bazel_dep(name = "platforms", version = "0.0.11") bazel_dep(name = "rules_java", version = "8.6.3") bazel_dep(name = "rules_proto", version = "7.1.0") -bazel_dep(name = "rules_python", version = "1.1.0") +bazel_dep(name = "rules_python", version = "1.2.0-rc0") bazel_dep(name = "rules_go", version = "0.53.0") bazel_dep(name = "rules_uv", version = "0.56.0") From cf21d09747ea87a3b57b47da577dc74b2d0ca20d Mon Sep 17 00:00:00 2001 From: Alex Eagle Date: Thu, 20 Feb 2025 13:21:09 -0800 Subject: [PATCH 2/2] chore: update location of toolchain type, accounting for rules_python breaking change --- examples/BUILD.bazel | 2 +- examples/MODULE.bazel | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/examples/BUILD.bazel b/examples/BUILD.bazel index 57fc72d..5eda38d 100644 --- a/examples/BUILD.bazel +++ b/examples/BUILD.bazel @@ -1,6 +1,6 @@ load("@rules_go//proto:def.bzl", "go_proto_library") load("@rules_proto//proto:defs.bzl", "proto_library") -load("@rules_python//python:proto.bzl", "py_proto_library") +load("@protobuf//bazel:py_proto_library.bzl", "py_proto_library") package(default_visibility = ["//visibility:public"]) diff --git a/examples/MODULE.bazel b/examples/MODULE.bazel index 6d8023a..a7180ec 100644 --- a/examples/MODULE.bazel +++ b/examples/MODULE.bazel @@ -2,12 +2,20 @@ bazel_dep(name = "toolchains_protoc", version = "0.0.0") bazel_dep(name = "aspect_bazel_lib", version = "2.11.0") bazel_dep(name = "aspect_rules_py", version = "1.3.2") bazel_dep(name = "platforms", version = "0.0.11") +bazel_dep(name = "protobuf", version = "29.3") bazel_dep(name = "rules_java", version = "8.6.3") bazel_dep(name = "rules_proto", version = "7.1.0") bazel_dep(name = "rules_python", version = "1.2.0-rc0") bazel_dep(name = "rules_go", version = "0.53.0") bazel_dep(name = "rules_uv", version = "0.56.0") +# Need https://github.com/bazelbuild/rules_python/pull/2620 +git_override( + module_name = "rules_python", + commit = "e95f95f75c9078f252f5b03eca18cba12d2e2166", + remote = "https://github.com/alexeagle/rules_python.git", +) + # This example is in the same repo with the ruleset, so we should point to the code at HEAD # rather than use any release on the Bazel Central Registry. local_path_override(