Skip to content

fix(uv): Transition build deps of whls back to libs #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arrdem merged 3 commits into from
Jan 15, 2026
Merged

fix(uv): Transition build deps of whls back to libs #772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81a4666
fix(uv): Transition build deps of whls back to libs
arrdem Jan 9, 2026
2b7c730
Pre-commit changes
aspect-marvin Jan 9, 2026
05e9f1c
Revert with_cfg's original_settings usage; it didn't work out
arrdem Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion uv/private/defs.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,24 @@
load("@with_cfg.bzl", "with_cfg")
load("//py:defs.bzl", "py_library")

py_whl_library, _ = with_cfg(py_library).set(Label("//uv/private/constraints:lib_mode"), "whl").build()
LIB_MODE = "//uv/private/constraints:lib_mode"

py_whl_library, _ = with_cfg(py_library).set(Label(LIB_MODE), "whl").build()

def _lib_mode_transition_impl(settings, attr):
return {LIB_MODE: "lib"}

lib_mode_transition = transition(
implementation = _lib_mode_transition_impl,
inputs = [],
outputs = [LIB_MODE],
)

def _whl_mode_transition_impl(settings, attr):
return {LIB_MODE: "whl"}

whl_mode_transition = transition(
implementation = _whl_mode_transition_impl,
inputs = [],
outputs = [LIB_MODE],
)
10 changes: 10 additions & 0 deletions uv/private/sdist_build/rule.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ load("//py/private/py_venv:types.bzl", "VirtualenvInfo")

# buildifier: disable=bzl-visibility
load("//py/private/toolchain:types.bzl", "PY_TOOLCHAIN")
load("//uv/private:defs.bzl", "lib_mode_transition")

TAR_TOOLCHAIN = "@tar.bzl//tar/toolchain:type"
# UV_TOOLCHAIN = "@multitool//tools/uv:toolchain_type"
Expand Down Expand Up @@ -102,4 +103,13 @@ specified Python dependencies under the configured Python toochain.
# UV_TOOLCHAIN,
# FIXME: Add in a cc toolchain here
],
# KLUDGE: Reset the uv lib mode and force it to lib. This ensures that if
# the user requests a library graph as whl files instead of libraries AND we
# have to do an sdist build to create one of those whls, the sdist builds
# required to produce those whls will occur with their dependencies
# _installed as libraries_ rather than _present as whl files_.
#
# Otherwise the transitive deps of the venv will still be in whl mode and we
# get cool errors that `build` and other tools aren't installed.
cfg = lib_mode_transition,
)
Loading