Skip to content

Add data to py_venv rule #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2025
Merged

Add data to py_venv rule #534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e079dff
Add data to py_venv rule
keith Mar 4, 2025
3a6b509
chore: bazel run docs:update
alexeagle Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/venv.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion py/defs.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ py_image_layer = _py_image_layer

resolutions = _resolutions

def _py_binary_or_test(name, rule, srcs, main, deps = [], resolutions = {}, **kwargs):
def _py_binary_or_test(name, rule, srcs, main, data = [], deps = [], resolutions = {}, **kwargs):
# Compatibility with rules_python, see docs in py_executable.bzl
main_target = "{}.find_main".format(name)
determine_main(
Expand All @@ -76,6 +76,7 @@ def _py_binary_or_test(name, rule, srcs, main, deps = [], resolutions = {}, **kw
name = name,
srcs = srcs,
main = main_target,
data = data,
deps = deps,
resolutions = resolutions,
package_collisions = package_collisions,
Expand All @@ -84,6 +85,7 @@ def _py_binary_or_test(name, rule, srcs, main, deps = [], resolutions = {}, **kw

_py_venv(
name = "{}.venv".format(name),
data = data,
deps = deps,
imports = kwargs.get("imports"),
resolutions = resolutions,
Expand Down
9 changes: 9 additions & 0 deletions py/private/py_venv.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,15 @@ py_venv_rule = rule(
allow_files = True,
providers = [[PyInfo], [PyVirtualInfo]],
),
"data": attr.label_list(
doc = """Runtime dependencies of the program.

The transitive closure of the `data` dependencies will be available in the `.runfiles`
folder for this binary/test. The program may optionally use the Runfiles lookup library to
locate the data files, see https://pypi.org/project/bazel-runfiles/.
""",
allow_files = True,
),
"imports": attr.string_list(
doc = "List of import directories to be added to the PYTHONPATH.",
default = [],
Expand Down