fix: Add option to skip target without srcs #447
+12
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add option 'skip_if_no_srcs' to lint_clang_tidy aspect.
Set to True to skip target if it provides CcInfo but has no source files. By default this will generate an error.
See issue #406
Adding an option to skip these targets enables us to run
./lint.sh //package//...
even if some target has no source files, e.g. code generation targets.Changes are visible to end-users: yes
Add option 'skip_if_no_srcs' to lint_clang_tidy aspect.
Test plan
bazel build with lint_clang_tidy_aspect for a target that provides 'CcInfo' but does not have 'srcs' attribute.
With skip_if_no_srcs set to True:
Build completes with empty
target.AspectRulesLintClangTidy.out
file.Without new option / new option set to False: