Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested blocks render inline #116

Closed
Stumblinbear opened this issue Jun 17, 2023 · 9 comments
Closed

Nested blocks render inline #116

Stumblinbear opened this issue Jun 17, 2023 · 9 comments
Labels
bug Something isn't working

Comments

@Stumblinbear
Copy link

Describe the bug

When nesting block syntaxes, subsequent blocks no longer move to new lines

> leading paragraph
>
> > nested blockquote
>
> following paragraph

To Reproduce

  1. Create a MarkdownWidget containing the above text
  2. Issue occurs

Expected behavior

The nested blocks should render the same as if they weren't nested

Screenshots

image

Environment(please complete the following information):

[√] Flutter (Channel stable, 3.10.4, on Microsoft Windows [Version 10.0.19045.3086], locale en-US)    • Flutter version 3.10.4 on channel stable at C:\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 682aa387cf (12 days ago), 2023-06-05 18:04:56 -0500
    • Engine revision 2a3401c9bb
    • Dart version 3.0.3
    • DevTools version 2.23.1

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at C:\Users\Trevin Miller\AppData\Local\Android\Sdk
    • Platform android-33, build-tools 33.0.0
    • ANDROID_HOME = C:\Users\Trevin Miller\AppData\Local\Android\Sdk
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2022 17.5.3)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.5.33516.290
    • Windows 10 SDK version 10.0.22621.0

[√] Android Studio (version 2021.3)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[√] VS Code (version 1.79.2)
    • VS Code at C:\Users\Trevin Miller\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.66.0

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19045.3086]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 114.0.5735.110
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 114.0.1823.43

[√] Network resources
    • All expected network resources are available.

• No issues found!

mardown_widget: 2.2.0

Platform

Desktop and mobile, have not checked web

Source data
Please provide a minimal source data that can help locating the problem

import 'package:flutter/material.dart';
import 'package:markdown_widget/markdown_widget.dart';

class TestWidget extends StatelessWidget {
  const TestWidget({
    super.key,
  });

  @override
  Widget build(BuildContext context) {
    return const Scaffold(
      body: MarkdownWidget(
        data: '''
leading paragraph

> nested blockquote

following paragraph

> leading paragraph
>
> > nested blockquote
>
> following paragraph
''',
      ),
    );
  }
}
@Stumblinbear Stumblinbear added the bug Something isn't working label Jun 17, 2023
@asjqkkkk
Copy link
Owner

@Stumblinbear thanks for your issue, I'll try to fix it in the next version

@vellrya
Copy link

vellrya commented Aug 13, 2023

Hello.

It might be a good idea to change the colour of the quote text in a dark theme. Compare:
image

image

I think in a light theme the text of the quote looks much better for readability than in a dark theme.

The colours are assigned correctly in the code blocks (with MarkdownConfig):

image

image

@asjqkkkk
Copy link
Owner

@vellrya yes, I thinks it's a good idea, I‘ll implement it in the next version

@vellrya
Copy link

vellrya commented Nov 2, 2023

As I understand there is no such fix in version 2.3.1. Can I reopen the issue so that you will notice it before the next update?)

@asjqkkkk
Copy link
Owner

asjqkkkk commented Nov 3, 2023

As I understand there is no such fix in version 2.3.1. Can I reopen the issue so that you will notice it before the next update?)

Hi @vellrya , thanks for your reminder, the issue about the nested blocks had been fixed, please open a new issue to descript another problem

@vellrya
Copy link

vellrya commented Dec 14, 2023

Should the commit b0c930a fix the problem? Unfortunately, it didn't(

@asjqkkkk
Copy link
Owner

@vellrya sorry,I forget to add this function, I'll create an new issue to description this issue, and fix it

@asjqkkkk
Copy link
Owner

Hi @vellrya , the text color issue of quote in night mode has been fixed on markdown_widget v2.3.2+2
image

@vellrya
Copy link

vellrya commented Dec 15, 2023

Thank you very much)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants