Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MinGW Windows build fails #26

Closed
ashtonmeuser opened this issue May 5, 2023 · 5 comments
Closed

MinGW Windows build fails #26

ashtonmeuser opened this issue May 5, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@ashtonmeuser
Copy link
Owner

ashtonmeuser commented May 5, 2023

Requires a change to Wasmer. Spawned from this comment. Dependent on wasmerio/wasmer#3849. Also see WebAssembly/wasm-c-api#182.

@fire
Copy link

fire commented May 5, 2023

Can we run a hotpatch process on download? I don't know how long it'll take and I'd like to integrate godot-wasm this weekend into our build system.

@ashtonmeuser
Copy link
Owner Author

Yessir. Hotpatch applied in d8d7f0e (Godot 3.x) and a41d27d (Godot 4.x). Closing this but will loop back once upstream changes land.

@fire
Copy link

fire commented May 5, 2023

Awesome!

I really appreciate your work.

@fire
Copy link

fire commented May 5, 2023

@ashtonmeuser I think patch might not exist but git apply might

https://git-scm.com/docs/git-apply

We are assuming git exists.

@ashtonmeuser
Copy link
Owner Author

I really appreciate your work.

Right back at ya! This project has been massively improved by your feedback!

I think patch might not exist but git apply might. We are assuming git exists.

Huh I was kinda under the assumption that patch would be a safer assumption in an environment using MinGW and would work outside of a repo. We could always hedge our bets with if [ $(command -v patch) ]; then patch -p1 < wasm-mingw.patch; else git apply wasm-mingw.patch; fi.

@ashtonmeuser ashtonmeuser added bug Something isn't working and removed blocked Blocked by dependency labels May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants