Print error message and exit with non-zero status when ruleguard parse error occurs (golangci#1666)

sebastien-rosset · ashanbrown · commit d25f18d4221e · 2021-02-20T13:46:46.000-08:00
diff --git a/go.mod b/go.mod
@@ -13,7 +13,7 @@ require (
 	github.com/denis-tingajkin/go-header v0.4.2
 	github.com/esimonov/ifshort v1.0.1
 	github.com/fatih/color v1.10.0
-	github.com/go-critic/go-critic v0.5.3
+	github.com/go-critic/go-critic v0.5.4
 	github.com/go-xmlfmt/xmlfmt v0.0.0-20191208150333-d5b6f63a941b
 	github.com/gofrs/flock v0.8.0
 	github.com/golangci/check v0.0.0-20180506172741-cfe4005ccda2
diff --git a/go.sum b/go.sum
diff --git a/pkg/golinters/gocritic.go b/pkg/golinters/gocritic.go
@@ -122,7 +122,10 @@ func buildEnabledCheckers(lintCtx *linter.Context, linterCtx *gocriticlinter.Con
 			return nil, err
 		}
 
-		c := gocriticlinter.NewChecker(linterCtx, info)
+		c, err := gocriticlinter.NewChecker(linterCtx, info)
+		if err != nil {
+			return nil, err
+		}
 		enabledCheckers = append(enabledCheckers, c)
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -122,7 +122,10 @@ func buildEnabledCheckers(lintCtx linter.Context, linterCtx gocriticlinter.Con`
`122`	`122`	`return nil, err`
`123`	`123`	`}`
`124`	`124`
`125`		`- c := gocriticlinter.NewChecker(linterCtx, info)`
	`125`	`+ c, err := gocriticlinter.NewChecker(linterCtx, info)`
	`126`	`+ if err != nil {`
	`127`	`+ return nil, err`
	`128`	`+ }`
`126`	`129`	`enabledCheckers = append(enabledCheckers, c)`
`127`	`130`	`}`
`128`	`131`