fix: use 404 for Ash.Error.Query.NotFound

fix: properly fall back to `filter` or nothing for built-in not Found

Author: zachdaniel

lib/ash_json_api/error/error.ex

@@ -312,7 +312,7 @@ defimpl AshJsonApi.ToJsonApiError, for: Ash.Error.Query.NotFound do
   def to_json_api_error(error) do
     %AshJsonApi.Error{
       id: Ash.UUID.generate(),
-      status_code: AshJsonApi.Error.class_to_status(error.class),
+      status_code: 404,
       code: "not_found",
       title: "NotFound",
       detail: "could not be found",

lib/ash_json_api/error/not_found.ex

@@ -25,7 +25,7 @@ defmodule AshJsonApi.Error.NotFound do
       filter = error.filter
       resource = error.resource
 
-      if is_map(filter) || Keyword.keyword?(filter) do
+      if is_map(filter) || (Keyword.keyword?(filter) && filter not in [[], []]) do
         filter =
           Enum.map_join(filter, ", ", fn {key, value} ->
             try do
@@ -38,7 +38,11 @@ defmodule AshJsonApi.Error.NotFound do
 
         "No #{AshJsonApi.Resource.Info.type(resource)} record found with `#{filter}`"
       else
-        "No #{AshJsonApi.Resource.Info.type(resource)} record found with `#{inspect(filter)}`"
+        if is_nil(error.filter) do
+          "No #{AshJsonApi.Resource.Info.type(resource)} record found"
+        else
+          "No #{AshJsonApi.Resource.Info.type(resource)} record found with `#{inspect(filter)}`"
+        end
       end
     end
   end