Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace use of pkg_resources with importlib.metadata #941

Closed
eslavich opened this issue Mar 18, 2021 · 5 comments · Fixed by #1199
Closed

Replace use of pkg_resources with importlib.metadata #941

eslavich opened this issue Mar 18, 2021 · 5 comments · Fixed by #1199
Labels
enhancement

Comments

@eslavich
Copy link
Contributor

See discussions:

astropy/astropy#11091
pypa/pip#7413
@marscher
Copy link

marscher commented Aug 5, 2021

pkg_resources is the devil in terms of package import time.

@perrygreenfield
Copy link
Contributor

Have you followed the recommendations at the end of this page? https://asdf.readthedocs.io/en/latest/asdf/extending/resources.html#installing-resources-via-entry-points

@eslavich
Copy link
Contributor Author

We're still supporting Python 3.6 and 3.7, so we'll need to use the importlib.metadata shim in order to do this.

@nden
Copy link
Contributor

nden commented Sep 27, 2022

@WilliamJamieson Can this be closed?

@WilliamJamieson
Copy link
Contributor

No this cannot be closed.

@WilliamJamieson WilliamJamieson mentioned this issue Sep 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace use of pkg_resources with importlib WilliamJamieson/asdf
5 participants
@marscher @perrygreenfield @nden @eslavich @WilliamJamieson