Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hack for Gradle 5 + signed artifacts + gradle-bintray-plugin 1.8.4 #862

Merged
merged 1 commit into from
Nov 3, 2019

Conversation

Fiouz
Copy link
Contributor

@Fiouz Fiouz commented Nov 2, 2019

WARNING: since the Groovy Gradle API is modified, this breaks build
isolation when sharing a common Gradle daemon instance.

This hack works because gradle-bintray-plugin is using Groovy dynamic
compilation (i.e. compiled in Groovy without @CompileStatic) hence it is
affected by Groovy runtime meta-programming.

Tested with: Gradle 5.6.3 / gradle-bintray-plugin 1.8.4

#861
bintray/gradle-bintray-plugin#300

WARNING: since the Groovy Gradle API is modified, this breaks build
isolation when sharing a common Gradle daemon instance.

This hack works because gradle-bintray-plugin is using Groovy dynamic
compilation (i.e. compiled in Groovy without @CompileStatic) hence it is
affected by Groovy runtime meta-programming.

Tested with: Gradle 5.6.3 / gradle-bintray-plugin 1.8.4

asciidoctor#861
bintray/gradle-bintray-plugin#300
@robertpanzer robertpanzer merged commit 947d002 into asciidoctor:master Nov 3, 2019
@robertpanzer
Copy link
Member

Thanks a log! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants