Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sourcemap, catalog_assets and parse to OptionBuilder #825

Merged
merged 4 commits into from
Jun 11, 2019
Merged

Add sourcemap, catalog_assets and parse to OptionBuilder #825

merged 4 commits into from
Jun 11, 2019

Conversation

jmini
Copy link
Contributor

@jmini jmini commented Jun 2, 2019

Fixes #808

This PR do not contains the version bump to 2.1.0

@robertpanzer
Copy link
Member

Could you also please add an entry to the change log? :)

@jmini
Copy link
Contributor Author

jmini commented Jun 11, 2019

I implemented the changes.

@robertpanzer robertpanzer merged commit 70a7fa4 into asciidoctor:master Jun 11, 2019
@robertpanzer
Copy link
Member

Thank you!
Sorry for the delay. I am not as fast in reviewing as I’d like to be.

@jmini
Copy link
Contributor Author

jmini commented Jun 13, 2019

Thank you for merging this. No worry about the delay.
The pace of reviews in the Asciidoctor(J) project is great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertpanzer robertpanzer robertpanzer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OptionsBuilder: support for sourcemap
2 participants
@jmini @robertpanzer