Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InlineMacroProcessor must return a PhraseNode instead of a String #823

Merged
merged 2 commits into from
May 30, 2019
Merged

InlineMacroProcessor must return a PhraseNode instead of a String #823

merged 2 commits into from
May 30, 2019

Conversation

jmini
Copy link
Contributor

@jmini jmini commented May 29, 2019

Fixes #821

@jmini jmini mentioned this pull request May 29, 2019
Closed
@mojavelinux
Copy link
Member

Technically the Ruby implementation accepts either return types, but the String return type is considered deprecated. Thus, I support this change.

@jmini
Copy link
Contributor Author

jmini commented May 30, 2019

This PR is only about updating documentation & tests.

The API stays the same (expecting an Object as return type allow to return a String as previously or a PhraseNode).

@robertpanzer
Copy link
Member

Thanks for this update! 🎉

@robertpanzer robertpanzer merged commit 1a33db5 into asciidoctor:master May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2.0.0: InlineMacroProcessor returning a String
3 participants
@jmini @mojavelinux @robertpanzer