OSGI update #765
OSGI update #765
Conversation
twasyl
commented
Feb 2, 2019
twasyl
commented
- Update OSGI snippet in both README and JavaDoc because the behaviour has changed in 1.6.0
- Update artifact-version to 1.6.1
- Update artifact-version to 1.6.1
README.adoc
Outdated
| JavaEmbedUtils.initialize(Arrays.asList("uri:classloader:/gems/asciidoctor-1.5.8/lib")); <1><2> | ||
|
|
||
| Asciidoctor asciidoctor = create(this.getClass().getClassLoader()); <3> | ||
| Asciidoctor asciidoctor = create(Arrays.asList("uri:classloader:/gems/asciidoctor-1.5.8/lib")); <1> |
There was a problem hiding this comment.
Should this be asciidoctor-{artifact-version} instead of asciidoctor-1.5.8?
There was a problem hiding this comment.
Well, the gem within the final Jar is still named asciidoctor-1.5.8. I don’t know if it’s a typo but this is working in SlideshowFX
There was a problem hiding this comment.
Ah right :) Sorry for this.
Yes, here the different versioning shows up.
Maybe others might be confused too, like me and a comment highlighting this would be great.
Just saying that this has to use the version of the packaged version of Asciidoctor, not AsciidoctorJ.
There was a problem hiding this comment.
No problem at all :)
I just pushed a clarification within the README for the version number. Feel free to comment the modification :)
The version number corresponds to the Asciidoctor version, not the AsciidoctorJ one.
|
Thanks! |
