Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publishing fixes for the 1.6.0 branch #485

Merged
merged 8 commits into from
Jul 19, 2016
Merged

Publishing fixes for the 1.6.0 branch #485

merged 8 commits into from
Jul 19, 2016

Conversation

robertpanzer
Copy link
Member

@robertpanzer robertpanzer commented Jul 16, 2016 •
edited
Loading

This PR tries to get the recent changes/fixes to the publishing originally done by @ancho on the master branch also to the asciidoctorj-1.6.0 branch.
Instead of cherry picking the multiple commits I tried to apply them manually, would be great if somebody could review.

Also cherry-picked the checkVersion build steps.

robertpanzer and others added 8 commits July 16, 2016 16:43
@robertpanzer
Applied changes to publishing as done before by @ancho on master branch
df8fac6
@ancho @robertpanzer
apply workaround for travis build with openjdk 7
8fc06db 
See travis-ci/travis-ci#5227 for more information
@ancho @robertpanzer
skip signing in travis builds explitcit to prevent the openjdk 6 buil…
aea1164 
…d to crash
@ancho @robertpanzer
add checkVersion Task to keep track of published gem versions
5e76d6d
@ancho @robertpanzer
Failsafe version of checkVersion Task
b11ca21 
Prevent stopping  check Task if an exception happens during checkVersion execution.
Print proper warning message if a version violates semantic versioning.

Closes asciidoctor#479
@robertpanzer
Don't apply checkVersion for documentation and test-support projects
caeb1bb
@robertpanzer
Avoid build error when property skip.signing is not set
5b5a2a6
@robertpanzer
Don't configure publicConfigs for deploying snapshots of distribution
a00553e
@ancho
Copy link
Contributor

ancho commented Jul 18, 2016

I tested the configuration. It works as expected.

  • bintrayUpload
    • with and without signing
  • checkVersion
    • skip works
  • generated pom is clean
    • with and without SNAPSHOT version
  • the build is obviously green for travis
  • appveyor does not seem to have a problem with the build configuration, but has a failing test.
    so it's kind of ok in that case.

@robertpanzer
Copy link
Member Author

Thanks for reviewing this!

@robertpanzer robertpanzer merged commit 78acf8c into asciidoctor:asciidoctorj-1.6.0 Jul 19, 2016
@robertpanzer robertpanzer deleted the publishing_1.6.0 branch July 19, 2016 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertpanzer @ancho