Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1237. -s CLI option should be changed to -e to align with Asci… #1238

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

robertpanzer
Copy link
Member

…idoctor

Thank you for opening a pull request and contributing to AsciidoctorJ!

Please take a bit of time giving some details about your pull request:

Kind of change

  • Bug fix
  • New non-breaking feature
  • New breaking feature
  • Documentation update
  • Build improvement

Description

What is the goal of this pull request?

Fix #1237 and change the command line option -e so that it creates an embedded document instead of selecting eRuby.

How does it achieve that?

Add a new cli option --embedded with the short key -e.
Change --eruby so that it doesn't have any short key.

Are there any alternative ways to implement this?

Likely not.

Are there any implications of this pull request? Anything a user must know?

I also removed the explicit mentionings of the defaults in the argument descriptions, since jcommander also shows the defaults, e.g.,:

    -e, --embedded
      suppress enclosing document structure and output an embedded document
      Default: false
    --eruby
      specify eRuby implementation to render built-in templates: [erb, erubis]
      Default: erb

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #1237

@robertpanzer robertpanzer merged commit 45f86e1 into asciidoctor:main Oct 30, 2023
11 checks passed
@robertpanzer robertpanzer deleted the fix-1237--s-cli-option branch October 30, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

-s CLI option should be changed to -e to align with Asciidoctor
2 participants