Fixes #1237. -s CLI option should be changed to -e to align with Asci… #1238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…idoctor
Thank you for opening a pull request and contributing to AsciidoctorJ!
Please take a bit of time giving some details about your pull request:
Kind of change
Description
What is the goal of this pull request?
Fix #1237 and change the command line option
-e
so that it creates an embedded document instead of selecting eRuby.How does it achieve that?
Add a new cli option
--embedded
with the short key-e
.Change
--eruby
so that it doesn't have any short key.Are there any alternative ways to implement this?
Likely not.
Are there any implications of this pull request? Anything a user must know?
I also removed the explicit mentionings of the defaults in the argument descriptions, since jcommander also shows the defaults, e.g.,:
Issue
If this PR fixes an open issue, please add a line of the form:
Fixes #1237