Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Java 19 by 21 (LTS) in CI #1236

Merged
merged 1 commit into from
Nov 25, 2023

Conversation

abelsromero
Copy link
Member

@abelsromero abelsromero commented Sep 21, 2023

Kind of change

  • Bug fix
  • New non-breaking feature
  • New breaking feature
  • Documentation update
  • Build improvement

Description

What is the goal of this pull request?

Test new Java LTS v21, and remove Java 19 which was not LTS.

How does it achieve that?

Replace Java17 in CI by Java21.
Also bumps SpringBoot test project to the latest 3.1.3.

Are there any alternative ways to implement this?

No

Are there any implications of this pull request? Anything a user must know?

No

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #Issue

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc

@abelsromero abelsromero force-pushed the bump-java-19-to-21 branch 3 times, most recently from 7844efa to bc53d02 Compare September 21, 2023 19:27
@abelsromero
Copy link
Member Author

😞 not yet available

   Trying to resolve the latest version from remote
  Error: Could not find satisfied version for SemVer '21'. 
  Available versions: 20.0.2+9, 20.0.1+9, 20.0.0+36, 19.0.2+7, 19.0.1+10, 19.0.0+36, 18.0.2+101, 18.0.2+9, 18.0.1+10, 18.0.0+36, 17.0.8+101, 17.0.8+7, 17.0.7+7, 17.0.6+10, 17.0.5+8, 17.0.4+101, 17.0.4+8, 17.0.3+7, 17.0.2+8, 17.0.1+12, 17.0.0+35, 16.0.2+7, 11.0.20+101, 11.0.20+8, 11.0.19+7, 11.0.18+10, 11.0.17+8, 11.0.16+101, 11.0.16+8, 11.0.15+10, 11.0.14+101, 11.0.14+9, 11.0.13+8, 11.0.12+7, 8.0.382+5, 8.0.372+7, 8.0.362+9, 8.0.352+8, 8.0.345+1, 8.0.342+7, 8.0.332+9, 8.0.322+6, 8.0.312+7, 8.0.302+8

Fun fact Graal is already available with graalvm/setup-graalvm@v1.

@abelsromero
Copy link
Member Author

I am thinking maybe we need to set a different distribution that is not temurin, sdkman has 21-open. I'll try later

@abelsromero abelsromero marked this pull request as draft September 22, 2023 12:53
@abelsromero
Copy link
Member Author

An Update, oracle distro is available, but only for 21, so I could fix Linux builds with some duplicated if conditions (not nice). It works for now but conflicts with other steps we run with if: always(), I'd give it another spin another moment.

@abelsromero
Copy link
Member Author

Still waiting 😞 ... https://adoptium.net/temurin/nightly/?version=21
image

@abelsromero abelsromero marked this pull request as ready for review November 25, 2023 16:04
@abelsromero
Copy link
Member Author

Updated configuration now that the Java 21 Temurin is available!

@abelsromero abelsromero merged commit e6298f0 into asciidoctor:main Nov 25, 2023
12 checks passed
@abelsromero abelsromero deleted the bump-java-19-to-21 branch November 25, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant