Replace JUnit4 by JUnit5 #1192
Merged
Replace JUnit4 by JUnit5 #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just realized we publish the
With that, we cover our needs, but maybe the |
abelsromero
force-pushed
the
issue-1186-remove-junit4
branch
from
7bc09d5
to
ecc710f
Compare
|
Made some more progress 🎉 the arquillian extension is not used but we can keep it, and only the wildfly-integration-test module uses junit 4 now. I am also thinking renaming |
abelsromero
force-pushed
the
issue-1186-remove-junit4
branch
3 times, most recently
from
56f6e36
to
0c51f2a
Compare
* Implement new Junit5 extensions: @AsciidoctorInstance & @ClasspathResource annotations available to inject Asciidoctor instances and resources into tests. * Update all modules to use JUnit5 and the new extensions 'asciidoctorj-wildfly-integration-test' remains on JUnit4 for Arquillian compatibility. Other changes: * Remove some uses of deprecated APIs * Fix typo in sample doc * Replace use of IOUtils.readFull(File) by Files.readString(Path) where possible to remove third-party dependencies. Closes asciidoctor#1186
|
Ready 🎉 |
|
Thank you for this! This is awesome! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of change
Description
What is the goal of this pull request?
Complete #1186. JUnit5 is the default now (only used in 'asciidoctorj-wildfly-integration-test' because of Arquillian).
And we have a new JUnit5 tools.
The Arquillian extension is left untouched.
How does it achieve that?
Replace Junit4 by Junit5
Are there any alternative ways to implement this?
Not on the base implementation, but the naming of the JUnit5 extensions annotations is open for debate 😅 (naming is hard).
Are there any implications of this pull request? Anything a user must know?
No.
Issue
This completely closes the issue 🎉
Fixes #1186
Release notes
Please add a corresponding entry to the file CHANGELOG.adoc
Already added.