Set Java11 as minimal version #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelsromero
force-pushed
the
issue-1150-set-java-11-as-minimal-support
branch
from
0835ffd
to
75b048b
Compare
|
Should we create a "Breaking changes" section in the CHANGELOG? I think it'd make the release notes much more simple when the time comes. |
abelsromero
force-pushed
the
issue-1150-set-java-11-as-minimal-support
branch
from
75b048b
to
38e22bc
Compare
|
Running tests in my repo to see if we can find a workaround for the Windows+Java17 issue. |
* Remove use of 'task.options.release' for Java version configuration in favour of Gradle's preferrs 'toolchain'. * Removed Java 8 from pipelines. * Bump Gradle to latest v8.0.2 * Remove use of 'io.spring.dependency-management' Gradle plugin in 'spring-boot' app in favor of Gradle's BOM support. This reduces maintenance since only Boot version needs to be updated. Fixes asciidoctor#1150 Remove unnecessary configurations
abelsromero
force-pushed
the
issue-1150-set-java-11-as-minimal-support
branch
from
38e22bc
to
fd8d730
Compare
|
Fixed the issue by forcing the toolchain version manually on Windows builds ONLY. It's sad but simple enough that with a simple comment, we can monitor it and remove it if it ever gets fixed. I am also keeping it in a separate commit, since AsciidoctorJ uses "merge pr" that will also make things easier to track. Since the release pipeline runs already on Java 11, there won't compatibility issues. The release will be 100% J11 binary. |
abelsromero
force-pushed
the
issue-1150-set-java-11-as-minimal-support
branch
from
fd8d730
to
4a64e3a
Compare
abelsromero
force-pushed
the
issue-1150-set-java-11-as-minimal-support
branch
from
4a64e3a
to
b7b307f
Compare
robertpanzer
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of change
Description
What is the goal of this pull request?
Remove support for Java 8 and set 11 as de minimal version.
Java8 is EOL and I don't think we should promote using it.
How does it achieve that?
Also:
Are there any alternative ways to implement this?
task.options.releasestill works, but Gradle docs suggest using the new toolchain configuration as this is the "preferred".Are there any implications of this pull request? Anything a user must know?
Users using Java 8 should stay in 2.5.x until they upgrade their apps.
Issue
If this PR fixes an open issue, please add a line of the form:
Fixes #1150
Release notes
Please add a corresponding entry to the file CHANGELOG.adoc