Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move CLI to its own subproject #246

Closed
mojavelinux opened this issue Dec 21, 2014 · 0 comments · Fixed by #1149
Closed

Move CLI to its own subproject #246

mojavelinux opened this issue Dec 21, 2014 · 0 comments · Fixed by #1149
Labels
improvement
Milestone
v1.5.3

Comments

@mojavelinux
Copy link
Member

I think we should move the CLI to its own subproject named asciidoctorj-cli. That way, we don't mix API concerns with CLI concerns. Now that we have a distribution, there is no additional overhead for the user in having a separate module since the distribution worries about setting up the classpath appropriately.
@mojavelinux mojavelinux changed the title Move Move CLI to its own subproject Dec 21, 2014
@mojavelinux mojavelinux added this to the v1.5.3 milestone Dec 21, 2014
@abelsromero abelsromero mentioned this issue Mar 21, 2023
Merged
5 tasks
abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue Mar 21, 2023
@abelsromero
Extract CLI Java components into new submodule
e9d53a6 
* Create new sub-module asciidoctorj-cli: migrated 'org.asciidoctor.jruby.cli'
classes and related tests to it.
* Created CliOptions in AsciidoctorUtils from values in AsciidoctorCliOptions
to avoid circular dependency.
* Updated README with new sub-module information.
* Fix jar names in command in README.
* Minor refactors and fixes.

Fixes asciidoctor#246
abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue Mar 21, 2023
@abelsromero
Extract CLI Java components into new submodule
520e506 
* Create new sub-module asciidoctorj-cli: migrated 'org.asciidoctor.jruby.cli'
classes and related tests to it.
* Created CliOptions in AsciidoctorUtils from values in AsciidoctorCliOptions
to avoid circular dependency.
* Updated README with new sub-module information.
* Fix jar names in command in README.
* Minor refactors and fixes.

Fixes asciidoctor#246
abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue Mar 21, 2023
@abelsromero
Extract CLI Java components into new submodule
80b18bb 
* Create new sub-module asciidoctorj-cli: migrated 'org.asciidoctor.jruby.cli'
classes and related tests to it.
* Created CliOptions in AsciidoctorUtils from values in AsciidoctorCliOptions
to avoid circular dependency.
* Updated README with new sub-module information.
* Fix jar names in command in README.
* Minor refactors and fixes.

Fixes asciidoctor#246
abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue Mar 23, 2023
@abelsromero
Extract CLI Java components into new submodule
648e0e7 
* Create new sub-module asciidoctorj-cli: migrated 'org.asciidoctor.jruby.cli'
classes and related tests to it.
* Created CliOptions in AsciidoctorUtils from values in AsciidoctorCliOptions
to avoid circular dependency.
* Updated README with new sub-module information.
* Fix jar names in command in README.
* Minor refactors and fixes.

Fixes asciidoctor#246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
v1.5.3
Development

Successfully merging a pull request may close this issue.

Extract CLI Java components into new submodule abelsromero/asciidoctorj
1 participant
@mojavelinux