Remove AsciidoctorUtils class #1169
Labels
Milestone
Comments
abelsromero
added a commit
to abelsromero/asciidoctorj
that referenced
this issue
Apr 7, 2023
This class contained a method to convert options into asciidoctor cli. Used only for logging and tests it's considered not useful. Other changes: * Add AssertJ dependency to Java projects by default * Refactored AsciidoctorUtils.isOptionWithAttribute into JRubyAsciidoctor.containsAttributeWithValue Fixes asciidoctor#1169
abelsromero
added a commit
to abelsromero/asciidoctorj
that referenced
this issue
Apr 7, 2023
This class contained a method to convert options into asciidoctor cli. Used only for logging and tests it's considered not useful. Other changes: * Add AssertJ dependency to Java projects by default * Refactored AsciidoctorUtils.isOptionWithAttribute into JRubyAsciidoctor.containsAttributeWithValue Fixes asciidoctor#1169
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Based on recent personal experience and the conversation, there seems to be a sentiment that this class is not useful, given it's used for logging and 1 test.
While the class is public it is in
internalpackage. If anyone is using it, it should not come as a surprise.Also, I am advocating removing it in v3.0.0 only, no need to add extra work for 2.5.x.
The text was updated successfully, but these errors were encountered: