Merge pull request #444 from robertpanzer/fix_443

Fixes #443. Don't fail when registering a treeprocessor with an unusu…

asciidoctorj-core/src/main/java/org/asciidoctor/extension/JavaExtensionRegistry.java

@@ -107,8 +107,7 @@ public void treeprocessor(Treeprocessor treeprocessor) {
     public void treeprocessor(Class<? extends Treeprocessor> treeProcessor) {
         // this may change in future to external class to deal with dynamic
         // imports
-        this.rubyRuntime
-                .evalScriptlet("java_import " + getImportLine(treeProcessor));
+        javaImport(rubyRuntime, treeProcessor);
         this.asciidoctorModule.treeprocessor(RubyUtils.toRubyClass(rubyRuntime, treeProcessor));
     }
 

asciidoctorj-core/src/test/java/org/asciidoctor/internal/WhenLoadingExtensionFromUnusualPackage.java

@@ -44,4 +44,22 @@ public void shouldAllowLoadingByClass() {
     registry.postprocessor(BoldifyPostProcessor.class);
   }
 
+  @Test
+  public void shouldAllowTreeprocessorLoadingUsingInstance() {
+    final JavaExtensionRegistry registry = asciidoctor.javaExtensionRegistry();
+    registry.treeprocessor(new unusual.extension.UnusualTreeProcessor());
+  }
+
+  @Test
+  public void shouldAllowTreeprocessorLoadingByClassName() {
+    final JavaExtensionRegistry registry = asciidoctor.javaExtensionRegistry();
+    registry.treeprocessor(unusual.extension.UnusualTreeProcessor.class.getCanonicalName());
+  }
+
+  @Test
+  public void shouldAllowTreeprocessorLoadingByClass() {
+    final JavaExtensionRegistry registry = asciidoctor.javaExtensionRegistry();
+    registry.treeprocessor(unusual.extension.UnusualTreeProcessor.class);
+  }
+
 }

asciidoctorj-core/src/test/java/unusual/extension/UnusualTreeProcessor.java

@@ -0,0 +1,19 @@
+package unusual.extension;
+
+import org.asciidoctor.ast.Document;
+import org.asciidoctor.extension.Postprocessor;
+import org.asciidoctor.extension.Treeprocessor;
+
+/**
+ * This processor is used only for checking we are able to load extensions from "unusual packages".
+ *
+ * @see org.asciidoctor.internal.WhenLoadingExtensionFromUnusualPackage
+ * @see <a href="https://github.com/asciidoctor/asciidoctorj/issues/250">Issue #250</a>
+ */
+public class UnusualTreeProcessor extends Treeprocessor {
+
+  @Override
+  public Document process(Document document) {
+    return document;
+  }
+}