Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase to the markdown extension code base #57

Closed
joaompinto opened this issue Mar 28, 2018 · 2 comments
Closed

Rebase to the markdown extension code base #57

joaompinto opened this issue Mar 28, 2018 · 2 comments
Assignees

Comments

@joaompinto
Copy link
Contributor

While planning for #11 I have noted that most of the VSCode markdown features make sense for asciidoc. As such, it will be more efficient/productive/maintainable to reuse as much as possible from the markdown code base, adapting just what is required for the different render engine (asciidoctor.js replacing markdown-it)

https://github.com/Microsoft/vscode/tree/master/extensions/markdown-language-features

Because this is a major feature/change, it will be worked in a new branch:
https://github.com/joaompinto/asciidoctor-vscode/tree/markdown-rebase

@joaompinto joaompinto self-assigned this Mar 28, 2018
@joaompinto joaompinto changed the title Rebase the extension using the markdown extension Rebase to the markdown extension code base Mar 28, 2018
@joaompinto
Copy link
Contributor Author

Instead of the branch, we will be using a new repository https://github.com/joaompinto/vscode-asciidoctor, this will allow for better tracking issues in relation to a new code base, and also getting a more used naming convention for the name (vscode-extension).

@joaompinto
Copy link
Contributor Author

Closing this issue for now, the built-in markdown depends on insiders-only API features and there is no plan to have such features available for general use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant