Adding new optional parameter auth_signin URL #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea is to check if the HTTP GET to auth_uri returns 401, then the proxy redirects the user to the URL specified in auth_signin. This reproduces the same functionality of https://kubernetes.github.io/ingress-nginx/examples/auth/oauth-external-auth/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks a lot for this plugin! Definitely a missing piece on kong's open source ecosystem (after all, the oauth2 plugin won't work in DB-less mode).
The idea of this patch is to check if the HTTP GET to auth_uri returns 401, then the proxy redirects the user to the URL specified in auth_signin. This reproduces the same functionality of https://kubernetes.github.io/ingress-nginx/examples/auth/oauth-external-auth/, thus allowing the use of a single sign-on URL when applicable.
The patch is meant to be backwards-compatible, as the auth_signin parameters is optional.