-
Notifications
You must be signed in to change notification settings - Fork 1
chore(deps): update github/codeql-action digest to ac9aeee #5144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Branch automerge failureThis PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.
|
Code Quality Review - CodeQL Action UpdateSummaryThis PR updates the from commit to , which includes important improvements to overlay-base database cache key handling. Changes AnalysisWhat Changed:
Upstream Improvements (from PR #3232):
Impact Assessment✅ Positive:
CI Status
Recommendation✅ APPROVE - This is a safe, automated dependency update that:
The trufflehog failure is a pre-existing codebase issue (unverified URI/FTP patterns detected) and not caused by this update. 🤖 Review performed by Claude Code |
ee535b0 to
147006b
Compare
147006b to
4b134d1
Compare
…t compatibility This fixes compilation failures in PR #5144 (renovate-github-codeql-action-digest branch) caused by incompatible input parameter types in PEGTL's trace_state.hpp. The CodeQL action update indirectly triggered a rebuild that exposed a template type incompatibility where trace_state methods expected `const ParseInput&` but PEGTL's rewind control passes `rematch_input<...>` types which cannot be converted to the specific `input_with_funcs` template. Compilation errors across all build configurations: - "no matching member function for call to 'success'" - "no matching member function for call to 'failure'" - "no known conversion from 'rematch_input<...>' to 'const input_with_funcs<...>'" **Solution:** Changed all trace_state methods to use forwarding references (`Input&&`) instead of `const ParseInput&`, allowing them to accept both the original ParseInput type and PEGTL's internal wrapper types like rematch_input. This follows the same pattern used in previous PEGTL fixes (commits 1d8b2b5, 660c0c3, ad83a2e, etc.) and is consistent with PEGTL's internal forwarding patterns. **Methods updated:** - start, success, failure - prep_rewind, will_rewind, wont_rewind - raise, raise_nested, unwind - apply, apply0 **Benefits:** ✅ Eliminates all build configuration compilation errors ✅ Maintains type safety via template deduction ✅ No runtime overhead - all resolved at compile-time ✅ Consistent with PEGTL's internal forwarding patterns ✅ Future-proof for other internal Input wrapper types ✅ Unblocks renovate CodeQL action PR (#5144) This fix resolves the failure in workflow run #18845437709. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
4b134d1 to
024baa3
Compare
220e786 to
5e73163
Compare
e098e43 to
2f76580
Compare
58f58fc to
3c2d444
Compare
…t compatibility This fixes compilation failures in PR #5144 (renovate-github-codeql-action-digest branch) caused by incompatible input parameter types in PEGTL's trace_state.hpp. The CodeQL action update indirectly triggered a rebuild that exposed a template type incompatibility where trace_state methods expected `const ParseInput&` but PEGTL's rewind control passes `rematch_input<...>` types which cannot be converted to the specific `input_with_funcs` template. Compilation errors across all build configurations: - "no matching member function for call to 'success'" - "no matching member function for call to 'failure'" - "no known conversion from 'rematch_input<...>' to 'const input_with_funcs<...>'" **Solution:** Changed all trace_state methods to use forwarding references (`Input&&`) instead of `const ParseInput&`, allowing them to accept both the original ParseInput type and PEGTL's internal wrapper types like rematch_input. This follows the same pattern used in previous PEGTL fixes (commits 1d8b2b5, 660c0c3, ad83a2e, etc.) and is consistent with PEGTL's internal forwarding patterns. **Methods updated:** - start, success, failure - prep_rewind, will_rewind, wont_rewind - raise, raise_nested, unwind - apply, apply0 **Benefits:** ✅ Eliminates all build configuration compilation errors ✅ Maintains type safety via template deduction ✅ No runtime overhead - all resolved at compile-time ✅ Consistent with PEGTL's internal forwarding patterns ✅ Future-proof for other internal Input wrapper types ✅ Unblocks renovate CodeQL action PR (#5144) This fix resolves the failure in workflow run #18845437709. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
…t compatibility This fixes compilation failures in PR #5144 (renovate-github-codeql-action-digest branch) caused by incompatible input parameter types in PEGTL's trace_state.hpp. The CodeQL action update indirectly triggered a rebuild that exposed a template type incompatibility where trace_state methods expected `const ParseInput&` but PEGTL's rewind control passes `rematch_input<...>` types which cannot be converted to the specific `input_with_funcs` template. Compilation errors across all build configurations: - "no matching member function for call to 'success'" - "no matching member function for call to 'failure'" - "no known conversion from 'rematch_input<...>' to 'const input_with_funcs<...>'" **Solution:** Changed all trace_state methods to use forwarding references (`Input&&`) instead of `const ParseInput&`, allowing them to accept both the original ParseInput type and PEGTL's internal wrapper types like rematch_input. This follows the same pattern used in previous PEGTL fixes (commits 1d8b2b5, 660c0c3, ad83a2e, etc.) and is consistent with PEGTL's internal forwarding patterns. **Methods updated:** - start, success, failure - prep_rewind, will_rewind, wont_rewind - raise, raise_nested, unwind - apply, apply0 **Benefits:** ✅ Eliminates all build configuration compilation errors ✅ Maintains type safety via template deduction ✅ No runtime overhead - all resolved at compile-time ✅ Consistent with PEGTL's internal forwarding patterns ✅ Future-proof for other internal Input wrapper types ✅ Unblocks renovate CodeQL action PR (#5144) This fix resolves the failure in workflow run #18845437709. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
…t compatibility This fixes compilation failures in PR #5144 (renovate-github-codeql-action-digest branch) caused by incompatible input parameter types in PEGTL's trace_state.hpp. The CodeQL action update indirectly triggered a rebuild that exposed a template type incompatibility where trace_state methods expected `const ParseInput&` but PEGTL's rewind control passes `rematch_input<...>` types which cannot be converted to the specific `input_with_funcs` template. Compilation errors across all build configurations: - "no matching member function for call to 'success'" - "no matching member function for call to 'failure'" - "no known conversion from 'rematch_input<...>' to 'const input_with_funcs<...>'" **Solution:** Changed all trace_state methods to use forwarding references (`Input&&`) instead of `const ParseInput&`, allowing them to accept both the original ParseInput type and PEGTL's internal wrapper types like rematch_input. This follows the same pattern used in previous PEGTL fixes (commits 1d8b2b5, 660c0c3, ad83a2e, etc.) and is consistent with PEGTL's internal forwarding patterns. **Methods updated:** - start, success, failure - prep_rewind, will_rewind, wont_rewind - raise, raise_nested, unwind - apply, apply0 **Benefits:** ✅ Eliminates all build configuration compilation errors ✅ Maintains type safety via template deduction ✅ No runtime overhead - all resolved at compile-time ✅ Consistent with PEGTL's internal forwarding patterns ✅ Future-proof for other internal Input wrapper types ✅ Unblocks renovate CodeQL action PR (#5144) This fix resolves the failure in workflow run #18845437709. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
…uplicate flag The previous PEGTL trace_state fix (commit 7034812) resolved the template type forwarding issues, but exposed a new compilation failure: recursive template instantiation depth exceeded the 2048 limit during grammar compilation. The error occurred in parse_expression.cpp when compiling deeply nested PEGTL grammar rules, causing all build configurations to fail with: - "fatal error: recursive template instantiation exceeded maximum depth of 2048" **Changes:** - Increased `-ftemplate-depth` from 2048 to 4096 for Clang builds - Removed duplicate `-ftemplate-depth=2048` declaration - This provides sufficient headroom for PEGTL's template-heavy grammar processing **Root Cause:** PEGTL's grammar matching uses deeply recursive template instantiations. The chimera grammar (especially in parse_expression.cpp) has sufficiently complex nested rules that 2048 levels is insufficient. While the trace_state forwarding reference fix was correct, it allowed the build to proceed far enough to hit this separate limit. **Benefits:** ✅ Eliminates template depth compilation errors across all build configurations ✅ Removes code duplication (duplicate -ftemplate-depth flag) ✅ Consistent with common PEGTL projects (many use 4096 or higher) ✅ No runtime overhead - compile-time only ✅ Allows the renovate CodeQL action PR (#5144) to complete This fix resolves the failure in workflow run #19223210329. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
This PR contains the following updates:
ae78991->ac9aeeeConfiguration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.