Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to add multiple classes for <hr> #131

Closed
tlylt opened this issue Oct 6, 2021 · 2 comments · Fixed by #133
Closed

Unable to add multiple classes for <hr> #131

tlylt opened this issue Oct 6, 2021 · 2 comments · Fixed by #133

Comments

@tlylt
Copy link
Contributor

tlylt commented Oct 6, 2021

This is an issue template. Fill in your problem description here, replacing this text. Below you should include examples.

Markdown-it versions:
├── [email protected]
├── [email protected]

Example input:

--- {.green .red}

Current output:

<hr class="green" class="red">

Expected output:

<hr class="green red">
@arve0
Copy link
Owner

arve0 commented Oct 6, 2021

Hi 👋 Thanks for reporting. Can confirm the behavior.

As this plugin does not render HTML, I believe the issue is with markdown-it, not markdown-it-attrs. Correct me if I'm wrong.

You can read more about rendering in the README, and also at markdown-it documentation: https://github.com/markdown-it/markdown-it/blob/master/docs/architecture.md#renderer

@tlylt
Copy link
Contributor Author

tlylt commented Oct 6, 2021

Hi 👋 Thanks for reporting. Can confirm the behavior.

As this plugin does not render HTML, I believe the issue is with markdown-it, not markdown-it-attrs. Correct me if I'm wrong.

You can read more about rendering in the README, and also at markdown-it documentation: https://github.com/markdown-it/markdown-it/blob/master/docs/architecture.md#renderer

Thank you for the quick response! Will close this issue and look into markdown-it instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants