Skip to content

Name of package is non obvious #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
toplenboren opened this issue Apr 2, 2024 · 3 comments
Closed

Name of package is non obvious #50

toplenboren opened this issue Apr 2, 2024 · 3 comments

Comments

@toplenboren
Copy link

Hi! Thanks for your work!

Really like your package :-) but I think the name isMartian is not really obvious.. You have to explain what a martian packet is every time you use it..

I think calling library isReservedIp(ip) might be more obvious for end user

What do you think?

@arty-name
Copy link
Owner

Thank you for your kind words!

Since the package doesn’t use named export, you can use any name you like for the imported function.

import isMartianIP from 'martian-cidr'; // suggested in the readme
import isReservedIp from 'martian-cidr'; // feel free to import it like this instead

Would that work for you?

@toplenboren
Copy link
Author

Yep, this might work for me :-) thanks for the prompt response!

@arty-name
Copy link
Owner

Sweet! I’ll mark it as resolved then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants