Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add baseline option #48

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Add baseline option #48

merged 1 commit into from
Oct 17, 2019

Conversation

bagage
Copy link
Contributor

@bagage bagage commented Oct 17, 2019

Fixes #24

Also fix an error with project access in DetektConfigStorage - sometime it lead to an exception.

@bagage bagage force-pushed the 24-add-baseline-option branch from 65328e9 to 35652d7 Compare October 17, 2019 12:18
arturbosch
arturbosch approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@arturbosch arturbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I will update the internal detekt version, do some tests and publish a new version.

@arturbosch arturbosch merged commit f840b0c into detekt:master Oct 17, 2019
@arturbosch arturbosch added this to the 0.3.2 milestone Oct 17, 2019
@bagage
Copy link
Contributor Author

bagage commented Oct 17, 2019

Awesome, thanks @arturbosch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arturbosch arturbosch arturbosch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.2
Development

Successfully merging this pull request may close these issues.

no possibility to specify the baseline.xml
2 participants
@bagage @arturbosch