Skip to content

Commit 107fe15

Browse files
WesSouzaarturbien
authored andcommitted
refactor(select): improve keyboard and events, split native to SelectNative
BREAKING CHANGE: Select props changed significantly, native is now the SelectNative component
1 parent 2a0d9ba commit 107fe15

17 files changed

+1845
-797
lines changed

package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
"access": "public"
3434
},
3535
"scripts": {
36-
"start": "cross-env STORYBOOK_DISPLAY_WARNING=true DISPLAY_WARNING=true start-storybook -p 9009",
36+
"start": "cross-env STORYBOOK_DISPLAY_WARNING=true DISPLAY_WARNING=true start-storybook -p 9009 --no-open",
3737
"build:storybook": "cross-env STORYBOOK_DISPLAY_WARNING=true DISPLAY_WARNING=true build-storybook -o ./storybook",
3838
"build": "rm -rf dist && yarn run build:prod",
3939
"build:dev": "cross-env NODE_ENV=development rollup -c",
@@ -82,6 +82,7 @@
8282
"@storybook/react": "6.5.10",
8383
"@testing-library/jest-dom": "^5.16.4",
8484
"@testing-library/react": "^12.1.5",
85+
"@testing-library/react-hooks": "^8.0.1",
8586
"@types/jest": "^28.1.6",
8687
"@types/react": "^18.0.15",
8788
"@types/react-dom": "^18.0.6",

src/DatePicker/DatePicker.tsx

+6-4
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import { Button } from '../Button/Button';
55
import { NumberInput } from '../NumberInput/NumberInput';
66
import { ScrollView } from '../ScrollView/ScrollView';
77
import { Select } from '../Select/Select';
8-
import { SelectChangeEvent } from '../Select/Select.types';
98
import { Toolbar } from '../Toolbar/Toolbar';
109
import { Window, WindowContent, WindowHeader } from '../Window/Window';
1110

@@ -101,9 +100,12 @@ const DatePicker = forwardRef<HTMLDivElement, DatePickerProps>(
101100
const [date, setDate] = useState(() => convertDateToState(initialDate));
102101
const { year, month, day } = date;
103102

104-
const handleMonthSelect = useCallback((e: SelectChangeEvent<number>) => {
105-
setDate(currentDate => ({ ...currentDate, month: e.target.value }));
106-
}, []);
103+
const handleMonthSelect = useCallback(
104+
({ value: monthSelected }: { value: number }) => {
105+
setDate(currentDate => ({ ...currentDate, month: monthSelected }));
106+
},
107+
[]
108+
);
107109

108110
const handleYearSelect = useCallback((yearSelected: number) => {
109111
setDate(currentDate => ({ ...currentDate, year: yearSelected }));

0 commit comments

Comments
 (0)