[Refactor] Delete Conversation and Purchases apps

src/desktop/index.ts

@@ -26,9 +26,7 @@ app.use(require("./apps/auctions"))
 app.use(require("./apps/auctions2").app)
 app.use(require("./apps/auction_lots"))
 
-// TODO: Remove after AB test ends.
-app.use(require("./apps/purchases/server").app)
-app.use(require("./apps/conversations/server").app)
+// FIXME: Remove once JSONPage + new app shell is worked out
 app.use(require("./apps/art_keeps_going/server").app)
 
 app.use(require("./apps/artists"))

src/v2/Apps/Conversation/Routes/Conversation/index.tsx

@@ -80,5 +80,3 @@ export const ConversationFragmentContainer = createFragmentContainer(
     `,
   }
 )
-
-export default ConversationFragmentContainer

src/v2/Apps/Conversation/routes.tsx

@@ -1,6 +1,7 @@
 import loadable from "@loadable/component"
 import { RouteConfig } from "found"
 import { graphql } from "react-relay"
+import { ConversationFragmentContainer as ConversationRoute } from "./Routes/Conversation"
 
 export const conversationRoutes: RouteConfig[] = [
   {
@@ -26,7 +27,7 @@ export const conversationRoutes: RouteConfig[] = [
   {
     path: "/user/conversations/:conversationID",
     displayFullPage: true,
-    getComponent: () => loadable(() => import("./Routes/Conversation")),
+    Component: ConversationRoute,
     prepareVariables: (params, _props) => {
       return {
         conversationID: params.conversationID,

src/v2/Apps/Purchase/PurchaseApp.tsx

@@ -7,6 +7,7 @@ import { Title } from "react-head"
 import { createFragmentContainer, graphql } from "react-relay"
 import { userIsAdmin } from "v2/Utils/user"
 import { PurchaseHistoryFragmentContainer as PurchaseHistory } from "./Components/PurchaseHistory"
+import { Spacer } from "@artsy/palette"
 
 export interface PurchaseAppProps {
   me: PurchaseApp_me
@@ -20,6 +21,7 @@ export const PurchaseApp = (props: any) => {
     return (
       <AppContainer>
         <Title>My Orders | Artsy</Title>
+        <Spacer mt={2} />
         <PurchaseHistory me={me} />
       </AppContainer>
     )
@@ -29,13 +31,12 @@ export const PurchaseApp = (props: any) => {
   }
 }
 
-export const PurchaseAppFragmentContainer = createFragmentContainer(
-  PurchaseApp,
-  {
-    me: graphql`
-      fragment PurchaseApp_me on Me {
-        ...PurchaseHistory_me
-      }
-    `,
-  }
-)
+const PurchaseAppFragmentContainer = createFragmentContainer(PurchaseApp, {
+  me: graphql`
+    fragment PurchaseApp_me on Me {
+      ...PurchaseHistory_me
+    }
+  `,
+})
+
+export default PurchaseAppFragmentContainer

src/v2/Apps/Purchase/__tests__/PurchaseApp.jest.tsx

@@ -9,7 +9,7 @@ import React from "react"
 import { HeadProvider } from "react-head"
 import { graphql } from "react-relay"
 import { PurchaseHistoryProps } from "../Components/PurchaseHistory"
-import { PurchaseAppFragmentContainer } from "../PurchaseApp"
+import PurchaseAppFragmentContainer from "../PurchaseApp"
 
 jest.unmock("react-relay")
 
@@ -72,7 +72,7 @@ const render = (me: PurchaseAppTestQueryRawResponse["me"], user: User) =>
         }
       }
     `,
-    wrapper: children => (
+    wrapper: (children) => (
       <MockBoot>
         <HeadProvider>
           <SystemContextProvider user={user}>{children}</SystemContextProvider>
@@ -126,10 +126,7 @@ describe("Purchase app", () => {
         const pagination = component.find("LargePagination")
         expect(pagination.length).toBe(1)
         expect(pagination.text()).toContain("1234...7")
-        pagination
-          .find("button")
-          .at(1)
-          .simulate("click")
+        pagination.find("button").at(1).simulate("click")
         expect(refetchSpy).toHaveBeenCalledTimes(1)
         expect(refetchSpy.mock.calls[0][0]).toEqual(
           expect.objectContaining({ first: 10, after: "NQ" })

src/v2/Apps/Purchase/routes.tsx

@@ -1,13 +1,11 @@
+import loadable from "@loadable/component"
 import { graphql } from "react-relay"
-
-// @ts-ignore
 import { RouteConfig } from "found"
-import { PurchaseAppFragmentContainer as PurchaseApp } from "./PurchaseApp"
 
 export const routes: RouteConfig[] = [
   {
     path: "/user/purchases",
-    Component: PurchaseApp,
+    getComponent: () => loadable(() => import("./PurchaseApp")),
     query: graphql`
       query routes_PurchaseQuery {
         me {

src/v2/Apps/getAppRoutes.tsx

@@ -6,6 +6,7 @@ import { collectRoutes } from "v2/Apps/Collect/collectRoutes"
 import { conversationRoutes } from "v2/Apps/Conversation/routes"
 import { routes as identityVerificationRoutes } from "v2/Apps/IdentityVerification/routes"
 import { routes as orderRoutes } from "v2/Apps/Order/routes"
+import { routes as purchasesRoutes } from "v2/Apps/Purchase/routes"
 import { routes as searchRoutes } from "v2/Apps/Search/routes"
 import { routes as viewingRoomRoutes } from "./ViewingRoom/routes"
 
@@ -29,6 +30,9 @@ export function getAppRoutes(): RouteConfig[] {
     {
       routes: orderRoutes,
     },
+    {
+      routes: purchasesRoutes,
+    },
     {
       routes: searchRoutes,
     },