Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(docker): build single architecture instead of multi arch image manifest #2781

Merged
merged 3 commits into from
May 22, 2024

Conversation

bernardobridge
Copy link
Contributor

@bernardobridge bernardobridge commented May 22, 2024

Description

Using the docker/build-push-action uses buildx and sets an image manifest type which is unsupported by Lambda. We now build the image with docker build as before, but setup qemu to ensure emulation is present for building arm64.

Note: builds arm64 conditionally so we can skip in PR's for now (given how long it takes). We can then add smoke tests to main against canary.

Testing

Tested this in another branch with a workflow_dispatch build, and locally triggered some Lambda tests against arm64 and x86_64. All seems to be working.

Pre-merge checklist

  • Does this require an update to the docs?
  • Does this require a changelog entry?

@bernardobridge bernardobridge requested a review from a team May 22, 2024 15:50
@bernardobridge bernardobridge marked this pull request as draft May 22, 2024 15:52
@bernardobridge bernardobridge marked this pull request as ready for review May 22, 2024 15:58
@bernardobridge bernardobridge changed the title ci(docker): use build with qemu instead of build ci(docker): use build with qemu instead of buildx May 22, 2024
@bernardobridge bernardobridge changed the title ci(docker): use build with qemu instead of buildx ci(docker): build single architecture instead of multi arch image manifest May 22, 2024
@bernardobridge bernardobridge merged commit b0be6be into main May 22, 2024
12 of 16 checks passed
@bernardobridge bernardobridge deleted the bernardobridge/art-1834-fix-buildx branch May 22, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant