Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents invoking future executor task if already cancelled. Fixes issue #33 #308

Closed
wants to merge 1 commit into from

Conversation

sagarpshah
Copy link

…sue #33

Description

Describe the change and/or the issue fixed in this pull request.
Please also include the context and motivation about the changes introduced.

Type of Change

  • New feature
  • Bug fix
  • Documentation

Checks

  • Changes support all platforms (Android, iOS, macOS, tvOS)
  • Breaks existing functionality
  • Implementation is completed, not half-done
  • Is there another PR already created for this feature/bug fix

Tests

How are these changes verified? Please provide test instructions.
Also list any relevant details about your test configuration.

Verified

This commit was signed with the committer’s verified signature.
miscco Michael Schellenberger Costa
…sue arthenica#33
@tanersener
Copy link
Collaborator

I don't see exactly what this PR fixes. #33 was an issue reported for v4.4. And we fixed that in v4.5.

If this PR includes an improvement then please fill out the Pull Request template fields. So we can understand the problem in the current approach and how this PR solves it. Please also see the Contributing section of the README.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants