Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing polluting console logs always shown #1045

Open
dprevost-LMI opened this issue Sep 22, 2024 · 2 comments
Open

Removing polluting console logs always shown #1045

dprevost-LMI opened this issue Sep 22, 2024 · 2 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@dprevost-LMI
Copy link

Description

Some console logs are always shown when using the library, which is polluting our logs and is not necessary. To not output some undesired logs, I remove one occurrence and hide the second under logLevel=debug

In our project, I see the following:
image

See suggested changes in this PR

@tanersener
Copy link
Collaborator

We use these lines to troubleshoot library load issues; not seeing the 'Loaded ...' message confirms a problem with the plugin.

The changes proposed in the PR remove these lines, and the if(logLevel === "debug") { check is always false, there's no way to enable it since these lines are the plugin’s first method calls. I’ll have to reject the PR, as it would make it harder to troubleshoot native library loading issues.

@tanersener tanersener added enhancement New feature or request wontfix This will not be worked on labels Oct 27, 2024
@dprevost-LMI
Copy link
Author

Interesting; if I change that for a disabled flag, would my PR be rejected again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants