No error raised on invalid dates

[ryantuck]

It seems like an error should be thrown on invalid dates, but this doesn't appear to happen. Is there some parameter I need to pass in to the get() function to enforce these are checked properly?

Using v0.12.1:

In [21]: import arrow

In [22]: arrow.get('2/30/2018')
Out[22]: <Arrow [2018-01-01T00:00:00+00:00]>

In [23]: arrow.get('13/4/2045')
Out[23]: <Arrow [2045-01-01T00:00:00+00:00]>

[akatcha]

I would like to tackle this. Any suggestions on where I can start?

[Luca409]

Actually, errors are raised for invalid dates that are correctly formatted:
>>> arrow.get('2018-02-30') Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/Library/Python/2.7/site-packages/arrow/api.py", line 23, in get return _factory.get(*args, **kwargs) File "/Library/Python/2.7/site-packages/arrow/factory.py", line 164, in get dt = parser.DateTimeParser(locale).parse_iso(arg) File "/Library/Python/2.7/site-packages/arrow/parser.py", line 110, in parse_iso return self._parse_multiformat(string, formats) File "/Library/Python/2.7/site-packages/arrow/parser.py", line 261, in _parse_multiformat _datetime = self.parse(string, fmt) File "/Library/Python/2.7/site-packages/arrow/parser.py", line 167, in parse return self._build_datetime(parts) File "/Library/Python/2.7/site-packages/arrow/parser.py", line 253, in _build_datetime tzinfo=parts.get('tzinfo')) ValueError: day is out of range for month

Notice that your output just points to January 1st of that year. There is a bug with parsing dates in that format. Either these dates need to be correctly parsed (and then the invalid date error can be raised), or dates in this format need to have the same effect as:

>>> >>> arrow.get('hello world') Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/Library/Python/2.7/site-packages/arrow/api.py", line 23, in get return _factory.get(*args, **kwargs) File "/Library/Python/2.7/site-packages/arrow/factory.py", line 164, in get dt = parser.DateTimeParser(locale).parse_iso(arg) File "/Library/Python/2.7/site-packages/arrow/parser.py", line 110, in parse_iso return self._parse_multiformat(string, formats) File "/Library/Python/2.7/site-packages/arrow/parser.py", line 267, in _parse_multiformat raise ParserError('Could not match input to any of {0} on \'{1}\''.format(formats, string)) arrow.parser.ParserError: Could not match input to any of [u'YYYY-MM-DD HH:mm'] on 'hello world'

[akatcha]

Good point. For consistency, which do you think is the best way to tackle this?

[Luca409]

I would count dates in the format "MM/DD/YYYY" as invalid for now.

[akatcha]

@Luca409 @ryantuck
I have submitted a pull request for this issue here: #527
Feel free to give it a review!