Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to change certain Thai translations in Locale #1127

Open
sanittawan opened this issue Oct 2, 2022 · 2 comments
Open

Proposal to change certain Thai translations in Locale #1127

sanittawan opened this issue Oct 2, 2022 · 2 comments

Comments

@sanittawan
Copy link

Hello! I'm a native Thai speaker who happened to stumble upon your project. I would love to propose the following changes as detailed in the comments.

    past = "{0} ที่ผ่านมา" # --> The present translation is fine, but it sounds more natural to use ที่แล้ว. 
                             # For example, if I use this library to print out the last check point, ที่แล้ว is more suitable

    timeframes = {
        "now": "ขณะนี้",
        "second": "วินาที", # --> this should be changed to "1 วินาที"
        "seconds": "{0} ไม่กี่วินาที", # --> this should be changed to "{0} วินาที"
        "minute": "1 นาที",
        "minutes": "{0} นาที",
        "hour": "1 ชั่วโมง",
        "hours": "{0} ชั่วโมง",
        "day": "1 วัน",
        "days": "{0} วัน",
        "month": "1 เดือน",
        "months": "{0} เดือน",
        "year": "1 ปี",
        "years": "{0} ปี",
    }

I'm happy to make these minor changes if you see fit and submit a pull request. I also saw that you are looking to improve test cases in various languages. I am happy to write some tests for Thai, but I need a bit more time to familiarize myself with the library. I'm fairly new to open source contribution as well, but would love to learn and do more.

@krisfremen
Copy link
Member

Hey @sanittawan,

Yes, please, go ahead and make a PR if you can.

We welcome all contributions!

@sanittawan
Copy link
Author

Thanks @krisfremen! I will get to it later in the week and will send a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants