Skip to content

Commit 444b7bc

Browse files
jurahulgithub-actions[bot]
authored andcommitted
Automerge: [NFC][DirectX] Fix build failure (#155441)
Add `BinaryFormat` to `LINK_COMPONENTS` to fix the following linker error: ``` ld.lld: error: undefined symbol: llvm::dxbc::getRootParameterTypes() >>> referenced by DXILRootSignature.cpp >>> lib/Target/DirectX/CMakeFiles/LLVMDirectXCodeGen.dir/DXILRootSignature.cpp.o:(llvm::dxil::RootSignatureAnalysisPrinter::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&)) ld.lld: error: undefined symbol: llvm::dxbc::getShaderVisibility() >>> referenced by DXILRootSignature.cpp >>> lib/Target/DirectX/CMakeFiles/LLVMDirectXCodeGen.dir/DXILRootSignature.cpp.o:(llvm::dxil::RootSignatureAnalysisPrinter::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&)) >>> referenced by DXILRootSignature.cpp >>> lib/Target/DirectX/CMakeFiles/LLVMDirectXCodeGen.dir/DXILRootSignature.cpp.o:(llvm::dxil::RootSignatureAnalysisPrinter::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&)) ``` Root cause: llvm/llvm-project#154249 changed a header-only dependency to a real dependency without noticing that the dependency was missing in CMakeLists.txt
2 parents d14d19a + 4a4b810 commit 444b7bc

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

llvm/lib/Target/DirectX/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ add_llvm_target(DirectXCodeGen
4141
LINK_COMPONENTS
4242
Analysis
4343
AsmPrinter
44+
BinaryFormat
4445
CodeGen
4546
CodeGenTypes
4647
Core

0 commit comments

Comments
 (0)