You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
But I think we are not going to merge that PR soon, it may be worthwhile to fix this one sooner. (I will work to finish the constraints PR of poly-commit soon.)
The text was updated successfully, but these errors were encountered:
The current
master
branch may fail to index a circuit because theindex
function would call:in
make_matrices_square_for_indexer
, before callinginline_all_lcs
.As a result, a developer would see "no symbolic LCs".
This problem is indeed fixed in the constraints PR #39 by removing a check in
make_matrices_square_for_indexer
.See https://github.com/arkworks-rs/marlin/pull/39/files#diff-4a24591214fb91bafc31f147e9f82b39471e7a773de92a5a36f0776f434c6158R54
But I think we are not going to merge that PR soon, it may be worthwhile to fix this one sooner. (I will work to finish the constraints PR of poly-commit soon.)
The text was updated successfully, but these errors were encountered: